[PATCH/RFA] Define various OS/ABI note types

[PATCH/RFA] Define various OS/ABI note types

[Jason R Thorpe]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

The following patch to include/elf/common.h defines the note types used by
GNU and NetBSD ABI identification notes.  These are needed by GDB.

OK to commit?

	* common.h (NT_GNU_ABI_TAG): Define.
	(GNU_ABI_TAG_LINUX): Define.
	(GNU_ABI_TAG_HURD): Define.
	(GNU_ABI_TAG_SOLARIS): Define.
	(NT_NETBSD_IDENT): Define.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>

[-- Attachment #2: elf-common-patch --]
[-- Type: text/plain, Size: 895 bytes --]

Index: common.h
===================================================================
RCS file: /cvs/src/src/include/elf/common.h,v
retrieving revision 1.41
diff -u -r1.41 common.h
--- common.h	31 Jan 2002 17:33:02 -0000	1.41
+++ common.h	7 May 2002 20:15:19 -0000
@@ -358,6 +358,17 @@
 #define NT_VERSION	1		/* Contains a version string.  */
 #define NT_ARCH		2		/* Contains an architecture string.  */
 
+/* Values for GNU .note.ABI-tag notes.  Note name is "GNU".  */
+
+#define NT_GNU_ABI_TAG		1
+#define GNU_ABI_TAG_LINUX	0
+#define GNU_ABI_TAG_HURD	1
+#define GNU_ABI_TAG_SOLARIS	2
+
+/* Values for NetBSD .note.netbsd.ident notes.  Note name is "NetBSD".  */
+
+#define NT_NETBSD_IDENT		1
+
 /* These three macros disassemble and assemble a symbol table st_info field,
    which contains the symbol binding and symbol type.  The STB_ and STT_
    defines identify the binding and type.  */

Re: [PATCH/RFA] Define various OS/ABI note types

[David O'Brien]

On Tue, May 07, 2002 at 01:18:33PM -0700, Jason R Thorpe wrote:
> The following patch to include/elf/common.h defines the note types used by
> GNU and NetBSD ABI identification notes.  These are needed by GDB.
> 
> OK to commit?

Please add the FreeBSD .note.ABI-tag if you are going to do this.
FreeBSD has a .note.ABI-tag with note type "1", vendor "FreeBSD", and
description that is a 6-digit number encoding major and minor version.

Re: [PATCH/RFA] Define various OS/ABI note types

[Jason R Thorpe]

On Tue, May 07, 2002 at 03:28:01PM -0700, David O'Brien wrote:

 > Please add the FreeBSD .note.ABI-tag if you are going to do this.
 > FreeBSD has a .note.ABI-tag with note type "1", vendor "FreeBSD", and
 > description that is a 6-digit number encoding major and minor version.

I can't find the actual definition of the version number encoding in
the FreeBSD header files.

If you can provide a precise description of it, I certainly have no
objections to including it in my patch.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>

Re: [PATCH/RFA] Define various OS/ABI note types

[David O'Brien]

On Tue, May 07, 2002 at 03:58:11PM -0700, Jason R Thorpe wrote:
> On Tue, May 07, 2002 at 03:28:01PM -0700, David O'Brien wrote:
> 
>  > Please add the FreeBSD .note.ABI-tag if you are going to do this.
>  > FreeBSD has a .note.ABI-tag with note type "1", vendor "FreeBSD", and
>  > description that is a 6-digit number encoding major and minor version.
> 
> I can't find the actual definition of the version number encoding in
> the FreeBSD header files.


The definition comes from src/lib/csu/common/crtbrand.c.

    static const struct {
        int32_t	namesz;
        int32_t	descsz;
        int32_t	type;
        char	name[sizeof "FreeBSD"];
        int32_t	desc;
    } abitag __attribute__ ((section (.note.ABI-tag))) = {
        sizeof "FreeBSD",
        sizeof(int32_t),
        1,
        "FreeBSD",
        __FreeBSD_version
    };

Where __FreeBSD_version is in sys/param.h.
On FreeBSD 5-CURRENT it is 500034 right now.  (I guess we actually have a
7-digit encoding)

Re: [PATCH/RFA] Define various OS/ABI note types

[Jason R Thorpe]

On Tue, May 07, 2002 at 04:11:44PM -0700, David O'Brien wrote:

 > Where __FreeBSD_version is in sys/param.h.
 > On FreeBSD 5-CURRENT it is 500034 right now.  (I guess we actually have a
 > 7-digit encoding)

...and that encoding is...?  (i.e. how are the fields in the number
split up?)

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>

Re: [PATCH/RFA] Define various OS/ABI note types

[David O'Brien]

On Tue, May 07, 2002 at 04:30:18PM -0700, Jason R Thorpe wrote:
> On Tue, May 07, 2002 at 04:11:44PM -0700, David O'Brien wrote:
> 
>  > Where __FreeBSD_version is in sys/param.h.
>  > On FreeBSD 5-CURRENT it is 500034 right now.  (I guess we actually have a
>  > 7-digit encoding)
> 
> ...and that encoding is...?  (i.e. how are the fields in the number
> split up?)

There is some historical baggage, but in the ELF world:

[0]5        major version number.
    0       minor version
     0034   34th significant change in 5.0 that needed an indicator

Another example from 4.5-STABLE, 450006
[0]4        major number
    5       minor number
     0006   6th significant change in 4.5 (before 4.6) that needed an
            indicator

All the various values are documented at
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-versions.html

Re: [PATCH/RFA] Define various OS/ABI note types

[Jason R Thorpe]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Tue, May 07, 2002 at 03:28:01PM -0700, David O'Brien wrote:

 > Please add the FreeBSD .note.ABI-tag if you are going to do this.
 > FreeBSD has a .note.ABI-tag with note type "1", vendor "FreeBSD", and
 > description that is a 6-digit number encoding major and minor version.

Ok, I've added the note type definition, but I have bothered adding
macros to decode the version number.

	* common.h (NT_GNU_ABI_TAG): Define.
	(GNU_ABI_TAG_LINUX): Define.
	(GNU_ABI_TAG_HURD): Define.
	(GNU_ABI_TAG_SOLARIS): Define.
	(NT_NETBSD_IDENT): Define.
	(NT_FREEBSD_ABI_TAG): Define.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>

[-- Attachment #2: elf-common-patch --]
[-- Type: text/plain, Size: 1002 bytes --]

Index: common.h
===================================================================
RCS file: /cvs/src/src/include/elf/common.h,v
retrieving revision 1.41
diff -u -r1.41 common.h
--- common.h	31 Jan 2002 17:33:02 -0000	1.41
+++ common.h	8 May 2002 05:26:44 -0000
@@ -358,6 +358,21 @@
 #define NT_VERSION	1		/* Contains a version string.  */
 #define NT_ARCH		2		/* Contains an architecture string.  */
 
+/* Values for GNU .note.ABI-tag notes.  Note name is "GNU".  */
+
+#define NT_GNU_ABI_TAG		1
+#define GNU_ABI_TAG_LINUX	0
+#define GNU_ABI_TAG_HURD	1
+#define GNU_ABI_TAG_SOLARIS	2
+
+/* Values for NetBSD .note.netbsd.ident notes.  Note name is "NetBSD".  */
+
+#define NT_NETBSD_IDENT		1
+
+/* Values for FreeBSD .note.ABI-tag notes.  Note name is "FreeBSD".  */
+
+#define NT_FREEBSD_ABI_TAG	1
+
 /* These three macros disassemble and assemble a symbol table st_info field,
    which contains the symbol binding and symbol type.  The STB_ and STT_
    defines identify the binding and type.  */

Re: [PATCH/RFA] Define various OS/ABI note types

[Nick Clifton]

Hi Jason,

> 	* common.h (NT_GNU_ABI_TAG): Define.
> 	(GNU_ABI_TAG_LINUX): Define.
> 	(GNU_ABI_TAG_HURD): Define.
> 	(GNU_ABI_TAG_SOLARIS): Define.
> 	(NT_NETBSD_IDENT): Define.
> 	(NT_FREEBSD_ABI_TAG): Define.

Approved - please apply.

Cheers
        Nick

Re: [PATCH/RFA] Define various OS/ABI note types

[David O'Brien]

On Tue, May 07, 2002 at 10:33:43PM -0700, Jason R Thorpe wrote:
> On Tue, May 07, 2002 at 03:28:01PM -0700, David O'Brien wrote:
> 
>  > Please add the FreeBSD .note.ABI-tag if you are going to do this.
>  > FreeBSD has a .note.ABI-tag with note type "1", vendor "FreeBSD", and
>  > description that is a 6-digit number encoding major and minor version.
> 
> Ok, I've added the note type definition, 

Thanks for adding this!

> but I have bothered adding
> macros to decode the version number.

That's fine, I didn't expect you to go to those lengths.

Re: [PATCH/RFA] Define various OS/ABI note types

[Jason R Thorpe]

On Wed, May 08, 2002 at 11:23:39AM -0700, David O'Brien wrote:

 > Thanks for adding this!

No sweat :-)

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>