From: Michael Snyder <msnyder@cygnus.com>
To: gdb-patches@sources.redhat.com
Cc: rearnsha@arm.com
Subject: [RFA] Disable "remote_rdp_can_run"
Date: Thu, 02 May 2002 16:31:00 -0000 [thread overview]
Message-ID: <200205022319.g42NJ8v07161@reddwarf.sfbay.redhat.com> (raw)
Happened across this. It's not right.
With this in place, if you have not attached to your rdp target
(ie. by saying "target rdp"), but you instead just say "run",
gdb will attempt to use the rdp target, which has not at this
point been opened or initialized. This is not the right way
to make a remote target accept the "run" command.
2002-05-02 Michael Snyder <msnyder@redhat.com>
* remote-rdp.c (remote_rdp_can_run): Return false. This is
not a good work-around for making a remote target accept 'run'.
Index: remote-rdp.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-rdp.c,v
retrieving revision 1.24
diff -p -r1.24 remote-rdp.c
*** remote-rdp.c 13 Feb 2002 16:24:59 -0000 1.24
--- remote-rdp.c 2 May 2002 23:25:40 -0000
*************** remote_rdp_create_inferior (char *exec_f
*** 1367,1373 ****
static int
remote_rdp_can_run (void)
{
! return 1;
}
/* Attach doesn't need to do anything */
--- 1367,1378 ----
static int
remote_rdp_can_run (void)
{
! /* You certainly can't run unles you've attached to your target board.
! If you want to save some sort of global state that tells you if
! you've attached, then maybe you can accept the run command
! (but I still don't think that would be right -- remote targets
! don't accept the run command (nor do they accept "attach")). */
! return 0;
}
/* Attach doesn't need to do anything */
next reply other threads:[~2002-05-02 23:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-02 16:31 Michael Snyder [this message]
2002-05-08 8:21 ` Richard Earnshaw
2002-05-08 11:35 ` Michael Snyder
2002-05-08 12:11 ` Richard Earnshaw
2002-05-09 11:45 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200205022319.g42NJ8v07161@reddwarf.sfbay.redhat.com \
--to=msnyder@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox