From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28780 invoked by alias); 2 May 2002 23:31:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28767 invoked from network); 2 May 2002 23:31:51 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 2 May 2002 23:31:51 -0000 Received: from reddwarf.sfbay.redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA13934; Thu, 2 May 2002 16:31:48 -0700 (PDT) Received: (from msnyder@localhost) by reddwarf.sfbay.redhat.com (8.11.2/8.11.2) id g42NJ8v07161; Thu, 2 May 2002 16:19:08 -0700 Date: Thu, 02 May 2002 16:31:00 -0000 From: Michael Snyder Message-Id: <200205022319.g42NJ8v07161@reddwarf.sfbay.redhat.com> To: gdb-patches@sources.redhat.com Subject: [RFA] Disable "remote_rdp_can_run" Cc: rearnsha@arm.com X-SW-Source: 2002-05/txt/msg00056.txt.bz2 Happened across this. It's not right. With this in place, if you have not attached to your rdp target (ie. by saying "target rdp"), but you instead just say "run", gdb will attempt to use the rdp target, which has not at this point been opened or initialized. This is not the right way to make a remote target accept the "run" command. 2002-05-02 Michael Snyder * remote-rdp.c (remote_rdp_can_run): Return false. This is not a good work-around for making a remote target accept 'run'. Index: remote-rdp.c =================================================================== RCS file: /cvs/src/src/gdb/remote-rdp.c,v retrieving revision 1.24 diff -p -r1.24 remote-rdp.c *** remote-rdp.c 13 Feb 2002 16:24:59 -0000 1.24 --- remote-rdp.c 2 May 2002 23:25:40 -0000 *************** remote_rdp_create_inferior (char *exec_f *** 1367,1373 **** static int remote_rdp_can_run (void) { ! return 1; } /* Attach doesn't need to do anything */ --- 1367,1378 ---- static int remote_rdp_can_run (void) { ! /* You certainly can't run unles you've attached to your target board. ! If you want to save some sort of global state that tells you if ! you've attached, then maybe you can accept the run command ! (but I still don't think that would be right -- remote targets ! don't accept the run command (nor do they accept "attach")). */ ! return 0; } /* Attach doesn't need to do anything */