From: "David S. Miller" <davem@redhat.com>
To: msnyder@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Improve Sparc epilogue analysis
Date: Wed, 24 Apr 2002 17:15:00 -0000 [thread overview]
Message-ID: <20020424.170539.73357679.davem@redhat.com> (raw)
In-Reply-To: <3CC73C70.A4BBA9D7@redhat.com>
From: Michael Snyder <msnyder@redhat.com>
Date: Wed, 24 Apr 2002 16:14:56 -0700
In this case, I don't believe you got the frameless_p case
right. First, you don't seem to have changed the definition
of SKIP_PROLOGUE_FRAMELESS_P in tm-sparc.h. Second, your
implementation of sparc_prologue_frameless_p is not
functionally equivalent to the old one. If it goes thru
the new, symbolic path, it will not return the same result.
SKIP_PROLOGUE_FRAMELESS_P died within the past day or two from the
whole GDB tree, perhaps you didn't notice :-)
Specifically, here:
2002-04-21 David S. Miller <davem@redhat.com>
* arch-utils.c (generic_prologue_frameless_p): Kill
SKIP_PROLOGUE_FRAMELESS_P code.
* config/arc/tm-arc.h (SKIP_PROLOGUE_FRAMELESS_P): Delete
references.
(PROLOGUE_FRAMELESS_P, arc_prologue_frameless_p): New.
* arc-tdep.c (arc_prologue_frameless_p): Implement.
* config/arc/tm-sparc.h (SKIP_PROLOGUE_FRAMELESS_P): Delete
references.
(PROLOGUE_FRAMELESS_P, sparc_prologue_frameless_p): New.
* sparc-tdep.c (sparc_prologue_frameless_p): Implement.
(sparc_gdbarch_init): Pass it to
set_gdbarch_prologue_frameless_p.
Posted here:
http://sources.redhat.com/ml/gdb-patches/2002-04/msg00727.html
I'd like to ask that you re-review this change, given this, please.
Thank you.
next prev parent reply other threads:[~2002-04-25 0:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-20 0:31 David S. Miller
2002-04-23 12:32 ` Michael Snyder
2002-04-24 0:09 ` David S. Miller
2002-04-24 16:27 ` Michael Snyder
2002-04-24 17:15 ` David S. Miller [this message]
2002-04-24 17:48 ` Michael Snyder
2002-04-24 17:54 ` David S. Miller
2002-04-24 18:02 ` David S. Miller
2002-04-25 14:11 ` Michael Snyder
2002-04-25 18:33 ` David S. Miller
2002-04-24 18:15 ` David S. Miller
2002-04-24 22:10 ` Eli Zaretskii
2002-04-25 11:44 ` Michael Snyder
2002-04-25 14:16 ` Michael Snyder
2002-04-25 18:38 ` David S. Miller
2002-04-24 19:10 ` David S. Miller
2002-04-25 14:25 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020424.170539.73357679.davem@redhat.com \
--to=davem@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox