From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-14766-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 2869 invoked by alias); 25 Apr 2002 00:15:24 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 2835 invoked from network); 25 Apr 2002 00:15:20 -0000
Received: from unknown (HELO pizda.ninka.net) (216.101.162.242)
  by 209.249.29.67 with SMTP; 25 Apr 2002 00:15:20 -0000
Received: from localhost (IDENT:davem@localhost.localdomain [127.0.0.1])
	by pizda.ninka.net (8.9.3/8.9.3) with ESMTP id RAA03168;
	Wed, 24 Apr 2002 17:05:39 -0700
Date: Wed, 24 Apr 2002 17:15:00 -0000
Message-Id: <20020424.170539.73357679.davem@redhat.com>
To: msnyder@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Improve Sparc epilogue analysis
From: "David S. Miller" <davem@redhat.com>
In-Reply-To: <3CC73C70.A4BBA9D7@redhat.com>
References: <3CC5B3DD.AE14C458@redhat.com>
	<20020423.235951.23032845.davem@redhat.com>
	<3CC73C70.A4BBA9D7@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-04/txt/msg00987.txt.bz2

   From: Michael Snyder <msnyder@redhat.com>
   Date: Wed, 24 Apr 2002 16:14:56 -0700

   In this case, I don't believe you got the frameless_p case 
   right.  First, you don't seem to have changed the definition
   of SKIP_PROLOGUE_FRAMELESS_P in tm-sparc.h.  Second, your
   implementation of sparc_prologue_frameless_p is not 
   functionally equivalent to the old one.  If it goes thru
   the new, symbolic path, it will not return the same result.
   
SKIP_PROLOGUE_FRAMELESS_P died within the past day or two from the
whole GDB tree, perhaps you didn't notice :-)

Specifically, here:

2002-04-21  David S. Miller  <davem@redhat.com>

        * arch-utils.c (generic_prologue_frameless_p): Kill
        SKIP_PROLOGUE_FRAMELESS_P code.
        * config/arc/tm-arc.h (SKIP_PROLOGUE_FRAMELESS_P): Delete
        references.
        (PROLOGUE_FRAMELESS_P, arc_prologue_frameless_p): New.
        * arc-tdep.c (arc_prologue_frameless_p): Implement.
        * config/arc/tm-sparc.h (SKIP_PROLOGUE_FRAMELESS_P): Delete
        references.
        (PROLOGUE_FRAMELESS_P, sparc_prologue_frameless_p): New.
        * sparc-tdep.c (sparc_prologue_frameless_p): Implement.
        (sparc_gdbarch_init): Pass it to
        set_gdbarch_prologue_frameless_p.

Posted here:

	http://sources.redhat.com/ml/gdb-patches/2002-04/msg00727.html

I'd like to ask that you re-review this change, given this, please.

Thank you.