From: Joel Brobecker <brobecker@ACT-Europe.FR>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] xfullpath and new regression test xfullpath.exp
Date: Wed, 03 Apr 2002 05:19:00 -0000 [thread overview]
Message-ID: <20020403151909.I26661@act-europe.fr> (raw)
In-Reply-To: <7458-Wed03Apr2002160810+0300-eliz@is.elta.co.il>; from eliz@is.elta.co.il on Wed, Apr 03, 2002 at 04:08:11PM +0300
> So please use HAVE_DOS_BASED_FILE_SYSTEM instead.
Sure, thanks for the tip.
> > if (IS_DIR_SEPARATOR (real_path[strlen (real_path) - 1]))
> > result = concat (real_path, base_name, NULL);
> > else
> > result = concat (real_path, SLASH_STRING, base_name, NULL);
>
> Yes, I think this is better, thanks.
>
> > (can I consider that SLASH_STRING will always be one character long?):
>
> Where does the code assume it's a single character? `concat' conses
> up a new string, right? If so, the length of SLASH_STRING shouldn't
> matter, I think. Or am I missing something?
I implicitely make this assumption when I use the IS_DIR_SEPARATOR
macro to check the value of the last character in the real_path string,
and then use SLASH_STRING during the concat.
If all is fine, I'll resubmit a new patch shortly.
--
Joel
next prev parent reply other threads:[~2002-04-03 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-01 0:50 Joel Brobecker
2002-04-01 1:43 ` Eli Zaretskii
2002-04-02 7:22 ` Joel Brobecker
2002-04-03 5:12 ` Eli Zaretskii
2002-04-03 5:19 ` Joel Brobecker [this message]
2002-04-04 23:44 ` Eli Zaretskii
2002-04-03 20:43 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020403151909.I26661@act-europe.fr \
--to=brobecker@act-europe.fr \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox