From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14437 invoked by alias); 3 Apr 2002 13:19:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14429 invoked from network); 3 Apr 2002 13:19:15 -0000 Received: from unknown (HELO dublin.ACT-Europe.FR) (212.157.227.154) by sources.redhat.com with SMTP; 3 Apr 2002 13:19:15 -0000 Received: from berlin.ACT-Europe.FR (berlin.int.act-europe.fr [10.10.0.169]) by dublin.ACT-Europe.FR (Postfix) with ESMTP id A6740229FFA; Wed, 3 Apr 2002 15:19:14 +0200 (MET DST) Received: by berlin.ACT-Europe.FR (Postfix, from userid 507) id 6BC56960; Wed, 3 Apr 2002 15:19:09 +0200 (CEST) Date: Wed, 03 Apr 2002 05:19:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] xfullpath and new regression test xfullpath.exp Message-ID: <20020403151909.I26661@act-europe.fr> References: <20020401105021.A13168@act-europe.fr> <20020402172232.C25687@act-europe.fr> <7458-Wed03Apr2002160810+0300-eliz@is.elta.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <7458-Wed03Apr2002160810+0300-eliz@is.elta.co.il>; from eliz@is.elta.co.il on Wed, Apr 03, 2002 at 04:08:11PM +0300 X-SW-Source: 2002-04/txt/msg00062.txt.bz2 > So please use HAVE_DOS_BASED_FILE_SYSTEM instead. Sure, thanks for the tip. > > if (IS_DIR_SEPARATOR (real_path[strlen (real_path) - 1])) > > result = concat (real_path, base_name, NULL); > > else > > result = concat (real_path, SLASH_STRING, base_name, NULL); > > Yes, I think this is better, thanks. > > > (can I consider that SLASH_STRING will always be one character long?): > > Where does the code assume it's a single character? `concat' conses > up a new string, right? If so, the length of SLASH_STRING shouldn't > matter, I think. Or am I missing something? I implicitely make this assumption when I use the IS_DIR_SEPARATOR macro to check the value of the last character in the real_path string, and then use SLASH_STRING during the concat. If all is fine, I'll resubmit a new patch shortly. -- Joel