* [RFA] testsuite fix for Mips ending-run.exp
@ 2002-03-27 11:57 Martin M. Hunt
2002-03-27 12:43 ` Andreas Schwab
2002-03-27 13:30 ` Michael Snyder
0 siblings, 2 replies; 4+ messages in thread
From: Martin M. Hunt @ 2002-03-27 11:57 UTC (permalink / raw)
To: gdb-patches
All my Mips testsuites fail on this, and it seems OK to me.
2002-03-27 Martin M. Hunt <hunt@redhat.com>
* gdb.base/ending-run.exp: Most Mips targets seem
to step out of main() into init().
Index: testsuite/gdb.base/ending-run.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ending-run.exp,v
retrieving revision 1.13
diff -u -p -r1.13 ending-run.exp
--- ending-run.exp 2002/02/10 18:58:26 1.13
+++ ending-run.exp 2002/03/27 19:55:06
@@ -178,6 +178,10 @@ gdb_expect {
# This is what happens on Sanyo XStormy16
pass "step out of main"
}
+ -re ".init ().*$gdb_prompt $" {
+ # This is what happens on many Mips targets
+ pass "step out of main"
+ }
-re ".*in ..change.mode ().*$gdb_prompt $" {
# This is what happens on ARM in thumb mode -fn 2000-02-01
pass "step out of main on ARM thumb"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFA] testsuite fix for Mips ending-run.exp
2002-03-27 11:57 [RFA] testsuite fix for Mips ending-run.exp Martin M. Hunt
@ 2002-03-27 12:43 ` Andreas Schwab
2002-03-27 13:43 ` Martin M. Hunt
2002-03-27 13:30 ` Michael Snyder
1 sibling, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2002-03-27 12:43 UTC (permalink / raw)
To: Martin M. Hunt; +Cc: gdb-patches
"Martin M. Hunt" <hunt@redhat.com> writes:
|> All my Mips testsuites fail on this, and it seems OK to me.
|>
|> 2002-03-27 Martin M. Hunt <hunt@redhat.com>
|>
|> * gdb.base/ending-run.exp: Most Mips targets seem
|> to step out of main() into init().
|>
|> Index: testsuite/gdb.base/ending-run.exp
|> ===================================================================
|> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ending-run.exp,v
|> retrieving revision 1.13
|> diff -u -p -r1.13 ending-run.exp
|> --- ending-run.exp 2002/02/10 18:58:26 1.13
|> +++ ending-run.exp 2002/03/27 19:55:06
|> @@ -178,6 +178,10 @@ gdb_expect {
|> # This is what happens on Sanyo XStormy16
|> pass "step out of main"
|> }
|> + -re ".init ().*$gdb_prompt $" {
^
Shouldn't this be ".*"?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE GmbH, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFA] testsuite fix for Mips ending-run.exp
2002-03-27 12:43 ` Andreas Schwab
@ 2002-03-27 13:43 ` Martin M. Hunt
0 siblings, 0 replies; 4+ messages in thread
From: Martin M. Hunt @ 2002-03-27 13:43 UTC (permalink / raw)
To: Andreas Schwab; +Cc: gdb-patches
On Wednesday 27 March 2002 12:43 pm, Andreas Schwab wrote:
> "Martin M. Hunt" <hunt@redhat.com> writes:
> |> All my Mips testsuites fail on this, and it seems OK to me.
> |>
> |> 2002-03-27 Martin M. Hunt <hunt@redhat.com>
> |>
> |> * gdb.base/ending-run.exp: Most Mips targets seem
> |> to step out of main() into init().
> |>
> |> Index: testsuite/gdb.base/ending-run.exp
> |> ===================================================================
> |> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ending-run.exp,v
> |> retrieving revision 1.13
> |> diff -u -p -r1.13 ending-run.exp
> |> --- ending-run.exp 2002/02/10 18:58:26 1.13
> |> +++ ending-run.exp 2002/03/27 19:55:06
> |> @@ -178,6 +178,10 @@ gdb_expect {
> |> # This is what happens on Sanyo XStormy16
> |> pass "step out of main"
> |> }
> |> + -re ".init ().*$gdb_prompt $" {
>
> ^
> Shouldn't this be ".*"?
Yes, although it tested fine without it because the line always starts with
"init ()". Anyway I'll put the "*" in. Thanks.
--
Martin Hunt
GDB Engineer
Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] testsuite fix for Mips ending-run.exp
2002-03-27 11:57 [RFA] testsuite fix for Mips ending-run.exp Martin M. Hunt
2002-03-27 12:43 ` Andreas Schwab
@ 2002-03-27 13:30 ` Michael Snyder
1 sibling, 0 replies; 4+ messages in thread
From: Michael Snyder @ 2002-03-27 13:30 UTC (permalink / raw)
To: Martin M. Hunt; +Cc: gdb-patches
"Martin M. Hunt" wrote:
>
> All my Mips testsuites fail on this, and it seems OK to me.
I think it's reasonable.
>
> 2002-03-27 Martin M. Hunt <hunt@redhat.com>
>
> * gdb.base/ending-run.exp: Most Mips targets seem
> to step out of main() into init().
>
> Index: testsuite/gdb.base/ending-run.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ending-run.exp,v
> retrieving revision 1.13
> diff -u -p -r1.13 ending-run.exp
> --- ending-run.exp 2002/02/10 18:58:26 1.13
> +++ ending-run.exp 2002/03/27 19:55:06
> @@ -178,6 +178,10 @@ gdb_expect {
> # This is what happens on Sanyo XStormy16
> pass "step out of main"
> }
> + -re ".init ().*$gdb_prompt $" {
> + # This is what happens on many Mips targets
> + pass "step out of main"
> + }
> -re ".*in ..change.mode ().*$gdb_prompt $" {
> # This is what happens on ARM in thumb mode -fn 2000-02-01
> pass "step out of main on ARM thumb"
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-03-27 21:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-03-27 11:57 [RFA] testsuite fix for Mips ending-run.exp Martin M. Hunt
2002-03-27 12:43 ` Andreas Schwab
2002-03-27 13:43 ` Martin M. Hunt
2002-03-27 13:30 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox