From: Daniel Jacobowitz <drow@mvista.com>
To: Jim Ingham <jingham@apple.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: add set cp-abi command
Date: Fri, 22 Mar 2002 10:34:00 -0000 [thread overview]
Message-ID: <20020322133420.A24693@nevyn.them.org> (raw)
In-Reply-To: <FF6060F4-3C77-11D6-80F8-000393540DDC@apple.com>
On Wed, Mar 20, 2002 at 07:01:53PM -0800, Jim Ingham wrote:
> >With the above changes it should be OK, although I would like to see
> >it. Thanks for following this through.
>
> Okay, let's see what Mail.app thinks is an attachment...
Not too bad, although I wish it knew how to mark them inline... in any
case, if you'll fix two tiny things this is approved.
! char *longname; /* These two can't be const, because I need to */
! char *doc; /* change the name for the auto abi. */
Comment formatting is against the GNU standard... I'd rather you just
kill the comment.
+ "Set the ABI used for inspecting C++ objects.\n\
+ \"set cp-abi\" with no arguments will list the available ABIs.", &setlist);
Replace with:
+ "Set the ABI used for inspecting C++ objects.\n"
+ "\"set cp-abi\" with no arguments will list the available ABIs.",
+ &setlist);
(or something like that; eliminating the \-return, which gcc3 I thought
would warn about...)
OK to commit with those changes.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-03-22 18:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-13 10:56 Jim Ingham
2002-03-13 12:11 ` Daniel Jacobowitz
2002-03-14 13:14 ` Jim Ingham
2002-03-14 13:26 ` Daniel Jacobowitz
2002-03-15 15:53 ` Jim Ingham
2002-03-15 19:41 ` Daniel Jacobowitz
2002-03-18 12:01 ` Jim Ingham
2002-03-20 15:19 ` Daniel Jacobowitz
2002-03-20 19:02 ` Jim Ingham
2002-03-22 10:34 ` Daniel Jacobowitz [this message]
2002-03-22 11:04 ` Andrew Cagney
2002-03-22 11:09 ` Daniel Jacobowitz
2002-03-22 11:29 ` Jim Ingham
2002-04-09 17:27 ` Jim Ingham
2002-04-09 17:54 ` Daniel Jacobowitz
2002-04-10 11:10 ` Jim Ingham
2002-04-10 11:58 ` Daniel Jacobowitz
2002-04-09 22:33 ` Eli Zaretskii
2002-04-10 11:14 ` Jim Ingham
2002-04-11 12:25 ` Eli Zaretskii
2002-03-15 17:11 ` Jim Ingham
2002-03-13 12:11 ` Eli Zaretskii
2002-03-14 15:29 ` Andrew Cagney
2002-03-15 10:33 ` Jim Ingham
2002-03-15 17:29 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020322133420.A24693@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jingham@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox