From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13467 invoked by alias); 22 Mar 2002 18:34:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13374 invoked from network); 22 Mar 2002 18:34:25 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 22 Mar 2002 18:34:25 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 16oTro-0006RE-00; Fri, 22 Mar 2002 13:34:20 -0500 Date: Fri, 22 Mar 2002 10:34:00 -0000 From: Daniel Jacobowitz To: Jim Ingham Cc: gdb-patches@sources.redhat.com Subject: Re: add set cp-abi command Message-ID: <20020322133420.A24693@nevyn.them.org> Mail-Followup-To: Jim Ingham , gdb-patches@sources.redhat.com References: <20020320181856.A17115@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i X-SW-Source: 2002-03/txt/msg00417.txt.bz2 On Wed, Mar 20, 2002 at 07:01:53PM -0800, Jim Ingham wrote: > >With the above changes it should be OK, although I would like to see > >it. Thanks for following this through. > > Okay, let's see what Mail.app thinks is an attachment... Not too bad, although I wish it knew how to mark them inline... in any case, if you'll fix two tiny things this is approved. ! char *longname; /* These two can't be const, because I need to */ ! char *doc; /* change the name for the auto abi. */ Comment formatting is against the GNU standard... I'd rather you just kill the comment. + "Set the ABI used for inspecting C++ objects.\n\ + \"set cp-abi\" with no arguments will list the available ABIs.", &setlist); Replace with: + "Set the ABI used for inspecting C++ objects.\n" + "\"set cp-abi\" with no arguments will list the available ABIs.", + &setlist); (or something like that; eliminating the \-return, which gcc3 I thought would warn about...) OK to commit with those changes. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer