From: Richard Earnshaw <rearnsha@arm.com>
To: Pierre Muller <muller@cerbere.u-strasbg.fr>
Cc: gdb-patches@sources.redhat.com, Richard.Earnshaw@arm.com
Subject: Re: PATCH multi-arch GET_LONGJMP_TARGET
Date: Tue, 19 Feb 2002 02:14:00 -0000 [thread overview]
Message-ID: <200202191013.KAA15886@cam-mail2.cambridge.arm.com> (raw)
In-Reply-To: Your message of "Tue, 19 Feb 2002 09:47:56 +0100." <4.2.0.58.20020219092651.00ad0668@ics.u-strasbg.fr>
>
> This patch makes that
> GET_LONGJMP_TARGET is always defined for all mutiarched target
> (even partial !).
>
> Thus it breaks compilation of Cygwin native GDB,
> because JB_PC and JB_ELEMENT_SIZE are not defined for these targets.
> (and several other i386 targets)
>
> The correct fix would be to add these values to gdbarch ...
>
> The following was committed as an obvious fix.
Ah, sorry about that.
Perhaps it would also be sensible to check GET_LONGJMP_TARGET_P() in that
code and always return 0 if it is false.
I'll go around the other tdep files and clean those up as well.
R.
next prev parent reply other threads:[~2002-02-19 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-18 5:38 Richard Earnshaw
2002-02-19 0:48 ` Pierre Muller
2002-02-19 2:14 ` Richard Earnshaw [this message]
2002-02-19 2:42 ` Richard Earnshaw
2002-02-20 2:49 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202191013.KAA15886@cam-mail2.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gdb-patches@sources.redhat.com \
--cc=muller@cerbere.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox