From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20659 invoked by alias); 19 Feb 2002 10:14:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20450 invoked from network); 19 Feb 2002 10:14:41 -0000 Received: from unknown (HELO fw-cam.cambridge.arm.com) (193.131.176.3) by sources.redhat.com with SMTP; 19 Feb 2002 10:14:41 -0000 Received: by fw-cam.cambridge.arm.com; id KAA15546; Tue, 19 Feb 2002 10:14:38 GMT Received: from unknown(172.16.1.2) by fw-cam.cambridge.arm.com via smap (V5.5) id xma015129; Tue, 19 Feb 02 10:13:59 GMT Received: from cam-mail2.cambridge.arm.com (localhost [127.0.0.1]) by cam-admin0.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id KAA07010; Tue, 19 Feb 2002 10:13:58 GMT Received: from sun18.cambridge.arm.com (sun18.cambridge.arm.com [172.16.2.18]) by cam-mail2.cambridge.arm.com (8.9.3/8.9.3) with ESMTP id KAA15886; Tue, 19 Feb 2002 10:13:54 GMT Message-Id: <200202191013.KAA15886@cam-mail2.cambridge.arm.com> X-Mailer: exmh version 2.0.2 2/24/98 To: Pierre Muller cc: gdb-patches@sources.redhat.com, Richard.Earnshaw@arm.com Reply-To: Richard.Earnshaw@arm.com Organization: ARM Ltd. X-Telephone: +44 1223 400569 (direct+voicemail), +44 1223 400400 (switchbd) X-Fax: +44 1223 400410 X-Address: ARM Ltd., 110 Fulbourn Road, Cherry Hinton, Cambridge CB1 9NJ. X-Url: http://www.arm.com/ Subject: Re: PATCH multi-arch GET_LONGJMP_TARGET In-reply-to: Your message of "Tue, 19 Feb 2002 09:47:56 +0100." <4.2.0.58.20020219092651.00ad0668@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Date: Tue, 19 Feb 2002 02:14:00 -0000 From: Richard Earnshaw X-SW-Source: 2002-02/txt/msg00492.txt.bz2 >=20 > This patch makes that > GET_LONGJMP_TARGET is always defined for all mutiarched target > (even partial !). >=20 > Thus it breaks compilation of Cygwin native GDB, > because JB_PC and JB_ELEMENT_SIZE are not defined for these targets. > (and several other i386 targets) >=20 > The correct fix would be to add these values to gdbarch ... >=20 > The following was committed as an obvious fix. Ah, sorry about that. Perhaps it would also be sensible to check GET_LONGJMP_TARGET_P() in that=20 code and always return 0 if it is false. I'll go around the other tdep files and clean those up as well. R.