GDBINIT_FILENAME macro in config/i386/xm-cygwin.h

GDBINIT_FILENAME macro in config/i386/xm-cygwin.h

[Pierre Muller]

xm-cygwin.h seems to define again GDBINIT_FILENAME to "gdb.ini",
thus gdb.ini is searched in home and current dir.

But looking into logs, Chistopher removed this in version 1.5,
as explained in the log, while Andrew reintroduced it,
but without any mention in the log.

Isn't that an error in the last commit of Andrew?

(extract of cvs log xm-cygwin.h)

revision 1.6
date: 2001/12/02 02:57:14;  author: cagney;  state: Exp;  lines: +2 -2
Delete HOST_BYTE_ORDER.
----------------------------
revision 1.5
date: 2001/11/24 18:21:26;  author: cgf;  state: Exp;  lines: +0 -10
* win32-nat.c (_initialize_check_for_gdb_ini): New function.
* config/i386/xm-cygwin.h: Remove obsolete handling of __CYGWIN32__.
(GDBINIT_FILENAME): Remove.

$ cvs diff -r 1.5 xm-cygwin.h
Index: xm-cygwin.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/xm-cygwin.h,v
retrieving revision 1.5
retrieving revision 1.6
diff -r1.5 -r1.6
21,22d20
< #define HOST_BYTE_ORDER LITTLE_ENDIAN
<
23a22,23
 >
 > #define GDBINIT_FILENAME "gdb.ini"



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: GDBINIT_FILENAME macro in config/i386/xm-cygwin.h

[Christopher Faylor]

On Thu, Feb 14, 2002 at 05:10:42PM +0100, Pierre Muller wrote:
>
>
>xm-cygwin.h seems to define again GDBINIT_FILENAME to "gdb.ini",
>thus gdb.ini is searched in home and current dir.
>
>But looking into logs, Chistopher removed this in version 1.5,
>as explained in the log, while Andrew reintroduced it,
>but without any mention in the log.
>
>Isn't that an error in the last commit of Andrew?

I'm sure that it is.  I've reverted the reversion.

Thanks for catching this.  I'm sure I would have been scratching my
head about this one for a while before I figured out what was going
on.

cgf

Re: GDBINIT_FILENAME macro in config/i386/xm-cygwin.h

[Pierre Muller]

At 17:33 14/02/2002 , Christopher Faylor a écrit:
>On Thu, Feb 14, 2002 at 05:10:42PM +0100, Pierre Muller wrote:
> >
> >
> >xm-cygwin.h seems to define again GDBINIT_FILENAME to "gdb.ini",
> >thus gdb.ini is searched in home and current dir.
> >
> >But looking into logs, Chistopher removed this in version 1.5,
> >as explained in the log, while Andrew reintroduced it,
> >but without any mention in the log.
> >
> >Isn't that an error in the last commit of Andrew?
>
>I'm sure that it is.  I've reverted the reversion.
>
>Thanks for catching this.  I'm sure I would have been scratching my
>head about this one for a while before I figured out what was going
>on.
Its simply because I didn't understand the meaning of the warning generated by the
_iniitialize_check_for_gdb_ini file. It said that I should rename gdb.ini to .gdbinit,
but when I did that, the file was not "sourced" anymore...

Now that its fixed again, I understand the comment.
Just one notice:
  this warning is only done for the $HOME/gdb.ini file,
should it be also issued if a gdb.ini exists in the current directory?
Because the GDBINIT_FILENAME is read first in $HOME dir
and after in the starting dir of the GDB executable.



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99

Re: GDBINIT_FILENAME macro in config/i386/xm-cygwin.h

[Christopher Faylor]

On Thu, Feb 14, 2002 at 05:51:48PM +0100, Pierre Muller wrote:
>At 17:33 14/02/2002 , Christopher Faylor a ?crit:
>>On Thu, Feb 14, 2002 at 05:10:42PM +0100, Pierre Muller wrote:
>> >
>> >
>> >xm-cygwin.h seems to define again GDBINIT_FILENAME to "gdb.ini",
>> >thus gdb.ini is searched in home and current dir.
>> >
>> >But looking into logs, Chistopher removed this in version 1.5,
>> >as explained in the log, while Andrew reintroduced it,
>> >but without any mention in the log.
>> >
>> >Isn't that an error in the last commit of Andrew?
>>
>>I'm sure that it is.  I've reverted the reversion.
>>
>>Thanks for catching this.  I'm sure I would have been scratching my
>>head about this one for a while before I figured out what was going
>>on.
>Its simply because I didn't understand the meaning of the warning generated by the
>_iniitialize_check_for_gdb_ini file. It said that I should rename gdb.ini to .gdbinit,
>but when I did that, the file was not "sourced" anymore...

Heh.

>Now that its fixed again, I understand the comment.
>Just one notice:
>  this warning is only done for the $HOME/gdb.ini file,
>should it be also issued if a gdb.ini exists in the current directory?
>Because the GDBINIT_FILENAME is read first in $HOME dir
>and after in the starting dir of the GDB executable.

Yes, it should check for this, too.

I'll look into extending the current behavior.

cgf

Re: GDBINIT_FILENAME macro in config/i386/xm-cygwin.h

[Andrew Cagney]

Thanks!

> n Thu, Feb 14, 2002 at 05:10:42PM +0100, Pierre Muller wrote:
> 
>>
>>
>>xm-cygwin.h seems to define again GDBINIT_FILENAME to "gdb.ini",
>>thus gdb.ini is searched in home and current dir.
>>
>>But looking into logs, Chistopher removed this in version 1.5,
>>as explained in the log, while Andrew reintroduced it,
>>but without any mention in the log.
>>
>>Isn't that an error in the last commit of Andrew?
> 
> 
> I'm sure that it is.  I've reverted the reversion.
> 
> Thanks for catching this.  I'm sure I would have been scratching my
> head about this one for a while before I figured out what was going
> on.
>