From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com, "Martin M. Hunt" <hunt@redhat.com>
Subject: Re: [RFA] fix for utils.c bool problem
Date: Fri, 08 Feb 2002 08:57:00 -0000 [thread overview]
Message-ID: <20020208115715.A21971@nevyn.them.org> (raw)
In-Reply-To: <3C6401FE.1060302@cygnus.com>
On Fri, Feb 08, 2002 at 11:51:10AM -0500, Andrew Cagney wrote:
> >This is the patch I alluded to earlier today on binutils@. It's not
> >>quite complete, since TUI is also affected; I've attached mine. I'm
> >>quite surprised that this fixes the problem for you without the
> >>corresponding bfd patch that I haven't committed yet!
> >
> >
> >No one objected, so I've committed this. As far as I know GDB should
> >build everywhere it used to before I started playing with bool, as long
> >as you update both BFD and GDB. If I'm wrong, please let me know.
>
>
> Dan I couldn't see the point of the patch. The immediate problem -
> bfd.h including <stdbool.h> was fixed. The next step, I thought, was
> fix bfd.h. It isn't hurting in a major way and definitly breaks GDB's
> coding style.
Sorry if I missed an objection. I was a little out of it yesterday.
The immediate problem was -not- fixed. To start back at the beginning
again:
- On my machine, running a current Debian system, <curses.h> includes
<stdbool.h>. We have to live with that. There's nothing I can
particularly do about it.
- The way I tried to fix this was by also using stdbool.h if it was
available. But <stdbool.h> conflicts with an awful lot of existing
code. This is unfortunate, and this is where the proper fix lies,
IMO.
- The way I settled on fixing this, and committed, was to use
<stdbool.h> if something included before bfd.h had already brought
it in. This appears to work in all cases.
I strongly want to avoid leaving GDB unbuildable on this class of
systems. I don't have any particular attachment to my patch. I would
love to revert it, as soon as there is an alternative solution in
place.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-02-08 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-07 13:33 Martin M. Hunt
2002-02-07 13:39 ` Daniel Jacobowitz
2002-02-07 14:01 ` Andrew Cagney
2002-02-07 14:14 ` Daniel Jacobowitz
2002-02-07 15:28 ` Andrew Cagney
2002-02-08 7:57 ` Daniel Jacobowitz
2002-02-08 8:51 ` Andrew Cagney
2002-02-08 8:57 ` Daniel Jacobowitz [this message]
2002-02-08 9:09 ` Andrew Cagney
2002-02-08 9:38 ` Daniel Jacobowitz
2002-02-08 10:55 ` Andrew Cagney
2002-02-28 22:04 ` Andrew Cagney
2002-02-07 13:40 ` Fernando Nasser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020208115715.A21971@nevyn.them.org \
--to=drow@mvista.com \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=hunt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox