Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Remove KERNEL_U_ADDR from config/nm-nbsd.h
@ 2002-01-18  9:56 Jason R Thorpe
  2002-01-18 10:07 ` Andrew Cagney
  0 siblings, 1 reply; 2+ messages in thread
From: Jason R Thorpe @ 2002-01-18  9:56 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

The following patch removes the definition of KERNEL_U_ADDR from
the NetBSD native configs.

The reason for doing so: the definition is completely bogus.  NetBSD
has not used the U-area for process or core file debugging for many
many years, and the U-area isn't even double-mapped at a fixed address
anymore (i.e. there is no "u.").

In addition, pulling in <machine/vmparam.h> (for the USRSTACK definition)
on some targets causes a compilation error, since this file is not meant
to be included directly (or by userland at all!).

	* config/nm-nbsd.h (KERNEL_U_ADDR): Remove.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>

[-- Attachment #2: nbsd-u-patch --]
[-- Type: text/plain, Size: 669 bytes --]

Index: config/nm-nbsd.h
===================================================================
RCS file: /cvs/src/src/gdb/config/nm-nbsd.h,v
retrieving revision 1.1.1.3
diff -c -r1.1.1.3 nm-nbsd.h
*** nm-nbsd.h	1999/12/14 01:05:40	1.1.1.3
--- nm-nbsd.h	2002/01/18 17:49:25
***************
*** 18,30 ****
     Foundation, Inc., 59 Temple Place - Suite 330,
     Boston, MA 02111-1307, USA.  */
  
- /* This is the amount to subtract from u.u_ar0
-    to get the offset in the core file of the register values.  */
- 
- #include <machine/vmparam.h>
- 
- #define KERNEL_U_ADDR USRSTACK
- 
  #define PTRACE_ARG3_TYPE char*
  
  #define FETCH_INFERIOR_REGISTERS
--- 18,23 ----

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFA] Remove KERNEL_U_ADDR from config/nm-nbsd.h
  2002-01-18  9:56 [RFA] Remove KERNEL_U_ADDR from config/nm-nbsd.h Jason R Thorpe
@ 2002-01-18 10:07 ` Andrew Cagney
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2002-01-18 10:07 UTC (permalink / raw)
  To: thorpej; +Cc: gdb-patches

> The following patch removes the definition of KERNEL_U_ADDR from
> the NetBSD native configs.
> 
> The reason for doing so: the definition is completely bogus.  NetBSD
> has not used the U-area for process or core file debugging for many
> many years, and the U-area isn't even double-mapped at a fixed address
> anymore (i.e. there is no "u.").
> 
> In addition, pulling in <machine/vmparam.h> (for the USRSTACK definition)
> on some targets causes a compilation error, since this file is not meant
> to be included directly (or by userland at all!).
> 
> 	* config/nm-nbsd.h (KERNEL_U_ADDR): Remove.


Ah.  Yes, approved.

Andrew




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-01-18 18:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-18  9:56 [RFA] Remove KERNEL_U_ADDR from config/nm-nbsd.h Jason R Thorpe
2002-01-18 10:07 ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox