Re: [RFA 2] Debug register support in win32-nat.c

[Christopher Faylor <cgf@redhat.com>]

On Tue, Jan 08, 2002 at 10:26:12AM +0100, Pierre Muller wrote:
>At 10:20 08/01/2002 , vous avez ?crit:
>>    This is a follow up of my first
>>proposal for win32 debug register support
>>(which enables hardware watchpoints,
>>I never tested the hardware breakpoints, as they don't have
>>much advantages over normal breakpoints on i386 processors).
>
>Sorry, I forgot to add the link
>http://sources.redhat.com/ml/gdb-patches/2001-11/msg00537.html
>and all the follow-ups.

I applied this patch but it doesn't seem to build.  I get a:
libgdb.a(win32-nat.o): In function `child_mourn_inferior':
/cygnus/src/uberbaum/gdb/win32-nat.c:1398: undefined reference to `_i386_cleanup_dregs'

I assume that this is related to your other patch.

In the meantime, I noticed a couple of things:

- ChangeLog needs to be wrapped to 80 columns.

- ChangeLog wording needs more verbs and more description.  For instance:
        (debug_registers_changed): Non zero whenever the debug registers where changed and
        need to be written to inferior.
   You need to mention that this is a new variable:
        (debug_registers_changed): New variable.  Reflects when debug registers are changed and
        need to be written to inferior.

- In do_initial_child_stuff, I'd prefer that you either use sizeof to
  derive the size of the dr array for zeroing or use a defined constant,
  rather than just a raw "7".

- I'm wondering if your implementation is thread safe?  You're storing
  debug registers in a global array and copying them into a structure
  as needed.  Couldn't they just be stored in the per-thread structure?
  You could add a debug_registers_used value to the structure, if necessary.

cgf