From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6959 invoked by alias); 13 Jan 2002 18:38:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6927 invoked from network); 13 Jan 2002 18:38:56 -0000 Received: from unknown (HELO lacrosse.corp.redhat.com) (12.107.208.154) by sources.redhat.com with SMTP; 13 Jan 2002 18:38:56 -0000 Received: from cgf.cipe.redhat.com (dhcpd206.meridian.redhat.com [172.16.47.206]) by lacrosse.corp.redhat.com (8.11.6/8.9.3) with ESMTP id g0DIcsE01471 for ; Sun, 13 Jan 2002 13:38:55 -0500 Received: (from cgf@localhost) by cgf.cipe.redhat.com (8.11.6/8.8.7) id g0DIdDU03750 for gdb-patches@sources.redhat.com; Sun, 13 Jan 2002 13:39:13 -0500 Date: Sun, 13 Jan 2002 10:38:00 -0000 From: Christopher Faylor To: gdb-patches@sources.redhat.com Subject: Re: [RFA 2] Debug register support in win32-nat.c Message-ID: <20020113183913.GD2647@redhat.com> Mail-Followup-To: gdb-patches@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4.2.0.58.20020108102529.021d6ac8@ics.u-strasbg.fr> User-Agent: Mutt/1.3.23.1i X-SW-Source: 2002-01/txt/msg00347.txt.bz2 On Tue, Jan 08, 2002 at 10:26:12AM +0100, Pierre Muller wrote: >At 10:20 08/01/2002 , vous avez ?crit: >> This is a follow up of my first >>proposal for win32 debug register support >>(which enables hardware watchpoints, >>I never tested the hardware breakpoints, as they don't have >>much advantages over normal breakpoints on i386 processors). > >Sorry, I forgot to add the link >http://sources.redhat.com/ml/gdb-patches/2001-11/msg00537.html >and all the follow-ups. I applied this patch but it doesn't seem to build. I get a: libgdb.a(win32-nat.o): In function `child_mourn_inferior': /cygnus/src/uberbaum/gdb/win32-nat.c:1398: undefined reference to `_i386_cleanup_dregs' I assume that this is related to your other patch. In the meantime, I noticed a couple of things: - ChangeLog needs to be wrapped to 80 columns. - ChangeLog wording needs more verbs and more description. For instance: (debug_registers_changed): Non zero whenever the debug registers where changed and need to be written to inferior. You need to mention that this is a new variable: (debug_registers_changed): New variable. Reflects when debug registers are changed and need to be written to inferior. - In do_initial_child_stuff, I'd prefer that you either use sizeof to derive the size of the dr array for zeroing or use a defined constant, rather than just a raw "7". - I'm wondering if your implementation is thread safe? You're storing debug registers in a global array and copying them into a structure as needed. Couldn't they just be stored in the per-thread structure? You could add a debug_registers_used value to the structure, if necessary. cgf