From: Daniel Jacobowitz <drow@mvista.com>
To: Jim Blandy <jimb@zwingli.cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/testsuite] Fix completion.exp on relative srcdir path
Date: Thu, 10 Jan 2002 18:49:00 -0000 [thread overview]
Message-ID: <20020110214951.A21944@nevyn.them.org> (raw)
In-Reply-To: <npd70hsj3d.fsf@zwingli.cygnus.com>
On Thu, Jan 10, 2002 at 09:43:34PM -0500, Jim Blandy wrote:
>
> Daniel Jacobowitz <drow@mvista.com> writes:
> > I always configure with relative paths - srcdir = ../../../src/gdb/testsuite
> > or so. That caused a bogus failure. Is this patch OK?
>
> What's behind the `cd ${objdir}' there that you're not doing anything
> with? Is the patch incomplete, or does it need to be cleaned up?
>
> If you address that, and add a comment explaining why what you're
> doing is necessary, then this patch looks good.
${srcdir} is a relative path - it starts with a '.'. Objdir is known
(IIRC) to be an absolute path. I'm reasonably sure that pwd will
always be objdir at this point, but not certain. It might still work
if I remove that line, though. I'll check.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-01-11 2:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 17:39 Daniel Jacobowitz
2002-01-10 18:42 ` Jim Blandy
2002-01-10 18:49 ` Daniel Jacobowitz [this message]
2002-01-13 14:13 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020110214951.A21944@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@zwingli.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox