From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6367 invoked by alias); 11 Jan 2002 02:49:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6247 invoked from network); 11 Jan 2002 02:49:54 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 11 Jan 2002 02:49:54 -0000 Received: from drow by nevyn.them.org with local (Exim 3.33 #1 (Debian)) id 16OrlP-0005iq-00; Thu, 10 Jan 2002 21:49:51 -0500 Date: Thu, 10 Jan 2002 18:49:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/testsuite] Fix completion.exp on relative srcdir path Message-ID: <20020110214951.A21944@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sources.redhat.com References: <20020109204006.A21094@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.23i X-SW-Source: 2002-01/txt/msg00276.txt.bz2 On Thu, Jan 10, 2002 at 09:43:34PM -0500, Jim Blandy wrote: > > Daniel Jacobowitz writes: > > I always configure with relative paths - srcdir = ../../../src/gdb/testsuite > > or so. That caused a bogus failure. Is this patch OK? > > What's behind the `cd ${objdir}' there that you're not doing anything > with? Is the patch incomplete, or does it need to be cleaned up? > > If you address that, and add a comment explaining why what you're > doing is necessary, then this patch looks good. ${srcdir} is a relative path - it starts with a '.'. Objdir is known (IIRC) to be an absolute path. I'm reasonably sure that pwd will always be objdir at this point, but not certain. It might still work if I remove that line, though. I'll check. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer