* [patch] Add ser-tcp.o to all NetBSD host Makefile fragments
@ 2002-01-04 14:14 Jason R Thorpe
2002-01-04 14:50 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: Jason R Thorpe @ 2002-01-04 14:14 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
The following adds ser-tcp.o to XDEPFILES to all NetBSD host
Makefile fragments. (It is already in the NetBSD/arm host
Makefile frag.)
OK to commit?
[ for gdb/ChangeLog ]
2002-01-04 Jason Thorpe <thorpej@wasabisystems.com>
* config/i386/nbsd.mh (XDEPFILES): Add ser-tcp.o.
Whitespace/comment cleanup.
* config/i386/nbsdelf.mh (XDEPFILES): Likewise.
* config/m68k/nbsd.mh (XDEPFILES): Likewise.
* config/ns32k/nbsd.mh (XDEPFILES): Likewise.
* config/powerpc/nbsd.mh (XDEPFILES): Likewise.
* config/sparc/nbsd.mh (XDEPFILES): Likewise.
* config/sparc/nbsdelf.mh (XDEPFILES): Likewise.
--
-- Jason R. Thorpe <thorpej@wasabisystems.com>
[-- Attachment #2: patch1 --]
[-- Type: text/plain, Size: 5332 bytes --]
Index: config/i386/nbsd.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/nbsd.mh,v
retrieving revision 1.10
diff -c -r1.10 nbsd.mh
*** nbsd.mh 2001/10/02 23:11:21 1.10
--- nbsd.mh 2002/01/04 21:56:51
***************
*** 1,13 ****
# Host: Intel 386 running NetBSD
! XDEPFILES=
!
! # NATDEPFILES must remain entirely on one line for *BSD. When
! # building a cross debugger, configure will cause this line to be
! # commented out in the Makefile. BSD make doesn't permit the use of a
! # continuation character (backslash) to extend a commented line. As a
! # consequence, BSD make considers subsequent tab-indented lines to be
! # "unassociated shell commands".
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o i386nbsd-nat.o solib.o solib-sunos.o
-
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsd.h
--- 1,5 ----
# Host: Intel 386 running NetBSD
! XDEPFILES= ser-tcp.o
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o i386nbsd-nat.o solib.o solib-sunos.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsd.h
Index: config/i386/nbsdelf.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/nbsdelf.mh,v
retrieving revision 1.6
diff -c -r1.6 nbsdelf.mh
*** nbsdelf.mh 2001/03/10 06:17:21 1.6
--- nbsdelf.mh 2002/01/04 21:56:51
***************
*** 1,5 ****
# Host: Intel 386 running NetBSD
! XDEPFILES=
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o i386nbsd-nat.o solib.o solib-svr4.o solib-legacy.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsdelf.h
--- 1,5 ----
# Host: Intel 386 running NetBSD
! XDEPFILES= ser-tcp.o
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o i386nbsd-nat.o solib.o solib-svr4.o solib-legacy.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsdelf.h
Index: config/m68k/nbsd.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/m68k/nbsd.mh,v
retrieving revision 1.8
diff -c -r1.8 nbsd.mh
*** nbsd.mh 2001/10/02 23:11:22 1.8
--- nbsd.mh 2002/01/04 21:56:51
***************
*** 1,5 ****
# Host: Motorola m68k running NetBSD
! XDEPFILES=
NATDEPFILES= infptrace.o inftarg.o fork-child.o corelow.o m68knbsd-nat.o solib.o solib-sunos.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsd.h
--- 1,5 ----
# Host: Motorola m68k running NetBSD
! XDEPFILES= ser-tcp.o
NATDEPFILES= infptrace.o inftarg.o fork-child.o corelow.o m68knbsd-nat.o solib.o solib-sunos.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsd.h
Index: config/ns32k/nbsd.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/ns32k/nbsd.mh,v
retrieving revision 1.8
diff -c -r1.8 nbsd.mh
*** nbsd.mh 2001/10/02 23:11:23 1.8
--- nbsd.mh 2002/01/04 21:56:51
***************
*** 1,5 ****
# Host: PC532 running NetBSD
! XDEPFILES=
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o ns32knbsd-nat.o solib.o solib-sunos.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsd.h
--- 1,5 ----
# Host: PC532 running NetBSD
! XDEPFILES= ser-tcp.o
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o ns32knbsd-nat.o solib.o solib-sunos.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsd.h
Index: config/powerpc/nbsd.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/nbsd.mh,v
retrieving revision 1.7
diff -c -r1.7 nbsd.mh
*** nbsd.mh 2001/08/27 02:22:14 1.7
--- nbsd.mh 2002/01/04 21:56:51
***************
*** 1,4 ****
# Host: PowerPC, running NetBSD
! XDEPFILES=
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o ppcnbsd-nat.o solib.o solib-svr4.o solib-legacy.o
NAT_FILE= nm-nbsd.h
--- 1,4 ----
# Host: PowerPC, running NetBSD
! XDEPFILES= ser-tcp.o
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o ppcnbsd-nat.o solib.o solib-svr4.o solib-legacy.o
NAT_FILE= nm-nbsd.h
Index: config/sparc/nbsd.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/sparc/nbsd.mh,v
retrieving revision 1.7
diff -c -r1.7 nbsd.mh
*** nbsd.mh 2001/10/02 23:11:24 1.7
--- nbsd.mh 2002/01/04 21:56:51
***************
*** 1,5 ****
# Host: Sun 4 or Sparcstation, running NetBSD
! XDEPFILES=
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o sparc-nat.o solib.o solib-sunos.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsd.h
--- 1,5 ----
# Host: Sun 4 or Sparcstation, running NetBSD
! XDEPFILES= ser-tcp.o
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o sparc-nat.o solib.o solib-sunos.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsd.h
Index: config/sparc/nbsdelf.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/sparc/nbsdelf.mh,v
retrieving revision 1.6
diff -c -r1.6 nbsdelf.mh
*** nbsdelf.mh 2001/03/10 06:17:24 1.6
--- nbsdelf.mh 2002/01/04 21:56:51
***************
*** 1,5 ****
# Host: Sun 4 or Sparcstation, running NetBSD
! XDEPFILES=
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o sparc-nat.o solib.o solib-svr4.o solib-legacy.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsdelf.h
--- 1,5 ----
# Host: Sun 4 or Sparcstation, running NetBSD
! XDEPFILES= ser-tcp.o
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o sparc-nat.o solib.o solib-svr4.o solib-legacy.o
XM_FILE= xm-nbsd.h
NAT_FILE= nm-nbsdelf.h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Add ser-tcp.o to all NetBSD host Makefile fragments
2002-01-04 14:14 [patch] Add ser-tcp.o to all NetBSD host Makefile fragments Jason R Thorpe
@ 2002-01-04 14:50 ` Andrew Cagney
2002-01-04 15:15 ` Jason R Thorpe
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2002-01-04 14:50 UTC (permalink / raw)
To: thorpej; +Cc: gdb-patches
Dig dig. Hmm, have a look at what configure.in does with SER_HARDWIRE.
Looks like the file needing a fix is config/arm/nbsd.mh.
As a rule of thumb, a host specific file should set off an alarm bell -
host specific stuff is (in theory ...) all handled by autoconf.
enjoy,
Andrew
PS: Why delete the comment.
> Index: config/i386/nbsd.mh
> ===================================================================
> RCS file: /cvs/src/src/gdb/config/i386/nbsd.mh,v
> retrieving revision 1.10
> diff -c -r1.10 nbsd.mh
> *** nbsd.mh 2001/10/02 23:11:21 1.10
> --- nbsd.mh 2002/01/04 21:56:51
> ***************
> *** 1,13 ****
> # Host: Intel 386 running NetBSD
> ! XDEPFILES=
> !
> ! # NATDEPFILES must remain entirely on one line for *BSD. When
> ! # building a cross debugger, configure will cause this line to be
> ! # commented out in the Makefile. BSD make doesn't permit the use of a
> ! # continuation character (backslash) to extend a commented line. As a
> ! # consequence, BSD make considers subsequent tab-indented lines to be
> ! # "unassociated shell commands".
> NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o i386nbsd-nat.o solib.o solib-sunos.o
> -
> XM_FILE= xm-nbsd.h
> NAT_FILE= nm-nbsd.h
> --- 1,5 ----
> # Host: Intel 386 running NetBSD
> ! XDEPFILES= ser-tcp.o
> NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o i386nbsd-nat.o solib.o solib-sunos.o
> XM_FILE= xm-nbsd.h
> NAT_FILE= nm-nbsd.h
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Add ser-tcp.o to all NetBSD host Makefile fragments
2002-01-04 14:50 ` Andrew Cagney
@ 2002-01-04 15:15 ` Jason R Thorpe
2002-01-04 15:32 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: Jason R Thorpe @ 2002-01-04 15:15 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Fri, Jan 04, 2002 at 05:50:31PM -0500, Andrew Cagney wrote:
> Dig dig. Hmm, have a look at what configure.in does with SER_HARDWIRE.
> Looks like the file needing a fix is config/arm/nbsd.mh.
Aha, I see. Ok.
> As a rule of thumb, a host specific file should set off an alarm bell -
> host specific stuff is (in theory ...) all handled by autoconf.
Then this patch ought to do the trick.
[ for gdb/ChangeLog ]
2002-01-04 Jason Thorpe <thorpej@wasabisystems.com>
* config/arm/nbsd.mh (XDEPFILES): Remove ser-tcp.o.
> PS: Why delete the comment.
Consistency with the others, mostly.
--
-- Jason R. Thorpe <thorpej@wasabisystems.com>
[-- Attachment #2: patch1 --]
[-- Type: text/plain, Size: 620 bytes --]
Index: config/arm/nbsd.mh
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/nbsd.mh,v
retrieving revision 1.2
diff -c -r1.2 nbsd.mh
*** nbsd.mh 2001/12/17 21:14:10 1.2
--- nbsd.mh 2002/01/04 23:10:55
***************
*** 1,5 ****
# Host ARM running NetBSD
! XDEPFILES= ser-tcp.o
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o armnbsd-nat.o
XM_FILE=xm-nbsd.h
NAT_FILE=nm-nbsd.h
--- 1,5 ----
# Host ARM running NetBSD
! XDEPFILES=
NATDEPFILES= fork-child.o infptrace.o inftarg.o corelow.o armnbsd-nat.o
XM_FILE=xm-nbsd.h
NAT_FILE=nm-nbsd.h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Add ser-tcp.o to all NetBSD host Makefile fragments
2002-01-04 15:15 ` Jason R Thorpe
@ 2002-01-04 15:32 ` Andrew Cagney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2002-01-04 15:32 UTC (permalink / raw)
To: thorpej; +Cc: gdb-patches
> Then this patch ought to do the trick.
>
> [ for gdb/ChangeLog ]
> 2002-01-04 Jason Thorpe <thorpej@wasabisystems.com>
>
> * config/arm/nbsd.mh (XDEPFILES): Remove ser-tcp.o.
>
yes, thanks.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-01-04 23:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-04 14:14 [patch] Add ser-tcp.o to all NetBSD host Makefile fragments Jason R Thorpe
2002-01-04 14:50 ` Andrew Cagney
2002-01-04 15:15 ` Jason R Thorpe
2002-01-04 15:32 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox