From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches <gdb-patches@sources.redhat.com>
Subject: [RFA]: testsuite/gdb.base/a2-bin.exp: Consider `needs_status_wrapper' target_info
Date: Wed, 05 Dec 2001 11:25:00 -0000 [thread overview]
Message-ID: <20011205202507.E29719@cygbert.vinschen.de> (raw)
Hi,
the first test in a2-bin.exp checks if the return code is 1 when
the application is called w/o parameter. Unfortunately there are
(remote) targets which aren't able to return a return code so that
the return code is always set to 0. That results in a failing
first test in a2-bin.exp even though the target is doing the right
thing.
To indicate that a target can't return a return code, there's
a setting `set_board_info needs_status_wrapper 1' which just
isn't taken into account in a2-bin.exp.
The following patch changes that.
Corinna
2001-12-05 Corinna Vinschen <vinschen@redhat.com>
* gdb.base/a2-bin.exp: Pass first test even if the return
code is 0 if target_info `needs_status_wrapper' exists.
Index: a2-run.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/a2-run.exp,v
retrieving revision 1.3
diff -u -p -r1.3 a2-run.exp
--- a2-run.exp 2001/03/06 08:21:50 1.3
+++ a2-run.exp 2001/12/05 19:10:31
@@ -80,6 +80,13 @@ if [istarget "*-*-vxworks*"] then {
-re ".*usage: factorial <number>.*Program exited with code 01.*$gdb_prompt $" {
pass "run \"$testfile\" with no args"
}
+ -re ".*usage: factorial <number>.*Program exited normally.*$gdb_prompt $" {
+ if [target_info exists needs_status_wrapper] then {
+ pass "run \"$testfile\" with no args"
+ } else {
+ fail "run \"$testfile\" with no args"
+ }
+ }
-re ".*$gdb_prompt $" {
fail "run \"$testfile\" with no args"
verbose "expect_out is $expect_out(buffer)" 2
--
Corinna Vinschen
Red Hat, Inc.
mailto:vinschen@redhat.com
next reply other threads:[~2001-12-05 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-05 11:25 Corinna Vinschen [this message]
2001-12-05 11:55 ` Daniel Jacobowitz
2001-12-05 12:17 ` Corinna Vinschen
2001-12-05 12:29 ` Daniel Jacobowitz
2002-01-21 8:12 ` Fernando Nasser
2002-01-20 16:08 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011205202507.E29719@cygbert.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox