From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4989 invoked by alias); 5 Dec 2001 19:25:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4965 invoked from network); 5 Dec 2001 19:25:11 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 5 Dec 2001 19:25:11 -0000 Received: from cygbert.vinschen.de (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA01974 for ; Wed, 5 Dec 2001 11:25:08 -0800 (PST) Received: (from corinna@localhost) by cygbert.vinschen.de (8.9.3/8.9.3/Linux sendmail 8.9.3) id UAA30131 for gdb-patches@sources.redhat.com; Wed, 5 Dec 2001 20:25:07 +0100 Date: Wed, 05 Dec 2001 11:25:00 -0000 From: Corinna Vinschen To: gdb-patches Subject: [RFA]: testsuite/gdb.base/a2-bin.exp: Consider `needs_status_wrapper' target_info Message-ID: <20011205202507.E29719@cygbert.vinschen.de> Reply-To: gdb-patches Mail-Followup-To: gdb-patches Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i X-SW-Source: 2001-12/txt/msg00141.txt.bz2 Hi, the first test in a2-bin.exp checks if the return code is 1 when the application is called w/o parameter. Unfortunately there are (remote) targets which aren't able to return a return code so that the return code is always set to 0. That results in a failing first test in a2-bin.exp even though the target is doing the right thing. To indicate that a target can't return a return code, there's a setting `set_board_info needs_status_wrapper 1' which just isn't taken into account in a2-bin.exp. The following patch changes that. Corinna 2001-12-05 Corinna Vinschen * gdb.base/a2-bin.exp: Pass first test even if the return code is 0 if target_info `needs_status_wrapper' exists. Index: a2-run.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/a2-run.exp,v retrieving revision 1.3 diff -u -p -r1.3 a2-run.exp --- a2-run.exp 2001/03/06 08:21:50 1.3 +++ a2-run.exp 2001/12/05 19:10:31 @@ -80,6 +80,13 @@ if [istarget "*-*-vxworks*"] then { -re ".*usage: factorial .*Program exited with code 01.*$gdb_prompt $" { pass "run \"$testfile\" with no args" } + -re ".*usage: factorial .*Program exited normally.*$gdb_prompt $" { + if [target_info exists needs_status_wrapper] then { + pass "run \"$testfile\" with no args" + } else { + fail "run \"$testfile\" with no args" + } + } -re ".*$gdb_prompt $" { fail "run \"$testfile\" with no args" verbose "expect_out is $expect_out(buffer)" 2 -- Corinna Vinschen Red Hat, Inc. mailto:vinschen@redhat.com