Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] mips argument passing fixes for o32
Date: Tue, 27 Nov 2001 07:48:00 -0000	[thread overview]
Message-ID: <20011127104816.C1939@nevyn.them.org> (raw)
Message-ID: <20011127074800.22Tu0dIUJpD-8I6ZFKqdAKpWBRZG1L4CELiuvoW8qWA@z> (raw)
In-Reply-To: <3B58AEBE.1000304@cygnus.com>

On Fri, Jul 20, 2001 at 06:20:46PM -0400, Andrew Cagney wrote:
> Daniel,
> 
> Just to close this current thread.  For the moment I'm rejecting the change:
> 
> >if (!MIPS_EABI
> >               && MIPS_SAVED_REGSIZE < 8
> >-              && TARGET_BYTE_ORDER == BIG_ENDIAN
> >+              && (TARGET_BYTE_ORDER == BIG_ENDIAN
> >+              || TYPE_LENGTH (arg_type) < MIPS_SAVED_REGSIZE)
> >               && partial_len < MIPS_SAVED_REGSIZE
> >               && (typecode == TYPE_CODE_STRUCT ||
> >               typecode == TYPE_CODE_UNION))
> 
> I need hard evidence (not comments from GCC) that LE o32 does indead 
> left shift small register structs.  I'll probably eventually get that 
> evidence however, until then I'd prefer to drop this change.

Meanwhile, to really close the current thread, I have adequately
convinced myself and the current MIPS GCC maintainer that GCC is in
error.  Hopefully be fixed soon in the dev snapshots, after he tests my
patch a little more.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


  parent reply	other threads:[~2001-11-27  7:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-06 11:26 Daniel Jacobowitz
2001-07-06 14:24 ` Andrew Cagney
2001-07-12  0:47 ` Andrew Cagney
2001-07-12 10:35   ` Daniel Jacobowitz
2001-07-12  1:23 ` Andrew Cagney
2001-07-12 10:39   ` Daniel Jacobowitz
2001-07-12 11:59     ` Andrew Cagney
2001-07-12 12:21       ` Daniel Jacobowitz
2001-07-12 12:38         ` Andrew Cagney
     [not found]       ` <3B58AEBE.1000304@cygnus.com>
     [not found]         ` <20010720152547.A10028@nevyn.them.org>
2001-07-20 16:35           ` Andrew Cagney
2001-07-20 16:46             ` Elena Zannoni
2001-07-23 20:36               ` Andrew Cagney
2001-11-14 14:15         ` Daniel Jacobowitz [this message]
2001-11-27  7:48           ` Daniel Jacobowitz
2001-07-12 17:03 David B Anderson
2001-07-15 14:50 ` Andrew Cagney
2001-07-15 15:22   ` Daniel Jacobowitz
2001-07-16  7:46     ` Andrew Cagney
2001-07-15 20:29 ` David B Anderson
2001-07-16 16:44   ` Andrew Cagney
2001-07-17  7:49   ` David B Anderson
2001-07-18 13:29     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011127104816.C1939@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox