* PATCH: Delete unused definition
@ 2001-11-08 11:26 Jim Blandy
2001-11-08 14:48 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Jim Blandy @ 2001-11-08 11:26 UTC (permalink / raw)
To: gdb-patches
Checked in as an obvious fix.
2001-11-20 Jim Blandy <jimb@redhat.com>
* target.h (TARGET_RANGE_PROFITABLE_FOR_HW_WATCHPOINT): Delete
default definition; this is never used.
Index: gdb/target.h
===================================================================
RCS file: /cvs/src/src/gdb/target.h,v
retrieving revision 1.20
diff -c -r1.20 target.h
*** gdb/target.h 2001/08/11 00:59:29 1.20
--- gdb/target.h 2001/11/21 01:58:26
***************
*** 1049,1065 ****
((LONGEST)(byte_count) <= REGISTER_SIZE)
#endif
- /* However, some addresses may not be profitable to use hardware to watch,
- or may be difficult to understand when the addressed object is out of
- scope, and hence should be unwatched. On some targets, this may have
- severe performance penalties, such that we might as well use regular
- watchpoints, and save (possibly precious) hardware watchpoints for other
- locations. */
-
- #if !defined(TARGET_RANGE_PROFITABLE_FOR_HW_WATCHPOINT)
- #define TARGET_RANGE_PROFITABLE_FOR_HW_WATCHPOINT(pid,start,len) 0
- #endif
-
/* Set/clear a hardware watchpoint starting at ADDR, for LEN bytes. TYPE is 0
for write, 1 for read, and 2 for read/write accesses. Returns 0 for
--- 1049,1054 ----
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: PATCH: Delete unused definition
2001-11-08 11:26 PATCH: Delete unused definition Jim Blandy
@ 2001-11-08 14:48 ` Eli Zaretskii
2001-11-08 15:21 ` Jim Blandy
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2001-11-08 14:48 UTC (permalink / raw)
To: jimb; +Cc: gdb-patches
> From: Jim Blandy <jimb@zwingli.cygnus.com>
> Date: Tue, 20 Nov 2001 21:01:38 -0500 (EST)
>
>
> Checked in as an obvious fix.
>
> 2001-11-20 Jim Blandy <jimb@redhat.com>
>
> * target.h (TARGET_RANGE_PROFITABLE_FOR_HW_WATCHPOINT): Delete
> default definition; this is never used.
Please note that this macro is documented in gdbint.texinfo.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: Delete unused definition
2001-11-08 14:48 ` Eli Zaretskii
@ 2001-11-08 15:21 ` Jim Blandy
0 siblings, 0 replies; 3+ messages in thread
From: Jim Blandy @ 2001-11-08 15:21 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches
Eli Zaretskii <eliz@is.elta.co.il> writes:
> > From: Jim Blandy <jimb@zwingli.cygnus.com>
> > Date: Tue, 20 Nov 2001 21:01:38 -0500 (EST)
> >
> >
> > Checked in as an obvious fix.
> >
> > 2001-11-20 Jim Blandy <jimb@redhat.com>
> >
> > * target.h (TARGET_RANGE_PROFITABLE_FOR_HW_WATCHPOINT): Delete
> > default definition; this is never used.
>
> Please note that this macro is documented in gdbint.texinfo.
Oops! Thanks. I'll delete that, too.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-11-21 21:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-11-08 11:26 PATCH: Delete unused definition Jim Blandy
2001-11-08 14:48 ` Eli Zaretskii
2001-11-08 15:21 ` Jim Blandy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox