From: Andrew Cagney <ac131313@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Elena Zannoni <ezannoni@cygnus.com>,
Fernando Nasser <fnasser@cygnus.com>,
gdb-patches@sources.redhat.com
Subject: Re: [RFA] arm-tdep.c: deal with failed memory read
Date: Sat, 17 Nov 2001 20:44:00 -0000 [thread overview]
Message-ID: <3C054819.30605@cygnus.com> (raw)
Message-ID: <20011117204400.5KHWVltK2-MgOmiv_qwynomYRuxiUennsS03Rj9wCl8@z> (raw)
In-Reply-To: <3C04615A.7020304@cygnus.com>
> The arm-tdep.c part is approved.
>
> We desperatly need a better naming convention and clearer semantics (what happens if the function fails due to a target disconnect) for these wrapped functions. gdb_*() is being used by both libgdb and wrapper.[hc] et.al.
Hmm, this doesn't read very well. Lets try ...
gdb.h contains gdb_...() libgdb functions.
wrapper.h contains gdb_...() save functions.
Two very different interfaces with identical prefixes. I think a
separate naming convention needs to be adopted for save / wrapped / ...
functions. I also think the function semantics need to be more tightly
defined. For instance, a safe function should catch a bad memory read,
should that safe function catch a failure because the target interface
has gone down (tcp connection lost, ...) or because the user entered a
cntrl-c.
Anyway, food for thought.
enjoy,
Andrew
next prev parent reply other threads:[~2001-11-28 20:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-09 1:18 Elena Zannoni
2001-11-10 10:13 ` Fernando Nasser
2001-11-15 12:54 ` Andrew Cagney
2001-11-27 20:00 ` Andrew Cagney
2001-11-28 12:25 ` Andrew Cagney [this message]
2001-11-17 20:44 ` Andrew Cagney
2001-12-19 15:54 ` Elena Zannoni
2001-12-05 14:41 ` Elena Zannoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C054819.30605@cygnus.com \
--to=ac131313@cygnus.com \
--cc=ezannoni@cygnus.com \
--cc=fnasser@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox