From: "Michael Snyder" <msnyder@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: [PATCH]: export write_register_gen
Date: Wed, 05 Sep 2001 00:15:00 -0000 [thread overview]
Message-ID: <8e9mhi$8lk$1@cronkite.cygnus.com> (raw)
Message-ID: <20010905001500.5o1e4MEVDmoQ5MFPi5a3f2ASokv1eptQCOO67HXVBUc@z> (raw)
In-Reply-To: <3907CF14.595754D5@cygnus.com>
Andrew Cagney wrote in message <3907CF14.595754D5@cygnus.com>...
>Michael Snyder wrote:
>
>> Yet write_register_gen is declared static. I thought I was
>> going to need it, so I wanted to export it. It turns out that
>> I don't need it, but I still think it should be public.
>
>Well, the interface is definitly less evil than read/write register
>bytes. So yes.
>(Looking at mips-tdep.c, I've been using write_register_bytes() as if it
>was write_register_gen().... )
Checked in the following:
2000-04-27 Michael Snyder <msnyder@seadog.cygnus.com>
* (write_register_gen): Export this useful interface.
* value.h (write_register_gen): Declare.
Index: findvar.c
===================================================================
RCS file: /cvs/src/src/gdb/findvar.c,v
retrieving revision 1.8
diff -c -r1.8 findvar.c
*** findvar.c 2000/04/17 02:27:36 1.8
--- findvar.c 2000/04/27 15:28:19
***************
*** 42,50 ****
#define CANNOT_STORE_REGISTER(regno) 0
#endif
! static void write_register_gen PARAMS ((int, char *));
! static int read_relative_register_raw_bytes_for_frame PARAMS ((int regnum,
cha
r *myaddr, struct frame_info * frame));
/* Basic byte-swapping routines. GDB has needed these for a long time...
All extract a target-format integer at ADDR which is LEN bytes long.
*/
--- 42,53 ----
#define CANNOT_STORE_REGISTER(regno) 0
#endif
! void write_register_gen PARAMS ((int, char *));
! static int
! read_relative_register_raw_bytes_for_frame PARAMS ((int regnum,
! char *myaddr,
! struct frame_info
*frame));
/* Basic byte-swapping routines. GDB has needed these for a long time...
All extract a target-format integer at ADDR which is LEN bytes long.
*/
***************
*** 777,783 ****
/* Write register REGNO at MYADDR to the target. MYADDR points at
REGISTER_RAW_BYTES(REGNO), which must be in target byte-order. */
! static void
write_register_gen (regno, myaddr)
int regno;
char *myaddr;
--- 780,786 ----
/* Write register REGNO at MYADDR to the target. MYADDR points at
REGISTER_RAW_BYTES(REGNO), which must be in target byte-order. */
! void
write_register_gen (regno, myaddr)
int regno;
char *myaddr;
Index: value.h
===================================================================
RCS file: /cvs/src/src/gdb/value.h,v
retrieving revision 1.3
diff -c -r1.3 value.h
*** value.h 2000/04/14 18:43:41 1.3
--- value.h 2000/04/27 15:30:33
***************
*** 464,469 ****
--- 464,472 ----
extern void
read_register_gen PARAMS ((int regno, char *myaddr));
+ extern void
+ write_register_gen PARAMS ((int regno, char *myaddr));
+
extern CORE_ADDR
read_register PARAMS ((int regno));
next parent reply other threads:[~2001-09-05 0:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <39078958.24CC@cygnus.com>
[not found] ` <3907CF14.595754D5@cygnus.com>
2000-04-27 8:45 ` Michael Snyder [this message]
2001-09-05 0:15 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='8e9mhi$8lk$1@cronkite.cygnus.com' \
--to=msnyder@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox