[PATCH] Get rid of redundant inclusion of <limits.h>

[PATCH] Get rid of redundant inclusion of <limits.h>

[Mark Kettenis]

Another step in reducing xm.h.  We already include <limits.h> from
"defs.h".  No need to do it again from xm.h.  Tested on
sparc-sun-solaris2.6 (which includes config/xm-sysv4.h).  Installed as
an obvious fix (head only).

Mark


Index: ChangeLog
from  Mark Kettenis  <kettenis@gnu.org>

	* config/xm-lynx.h, config/xm-nbsd.h, config/xm-sysv4.h,
	config/i386/xm-i386aix.h, config/m68k/xm-dpx2.h: Remove redundant
	inclusion of <limits.h>.

Index: config/xm-lynx.h
===================================================================
RCS file: /cvs/src/src/gdb/config/xm-lynx.h,v
retrieving revision 1.2
diff -u -p -r1.2 xm-lynx.h
--- config/xm-lynx.h 2001/03/06 08:21:20 1.2
+++ config/xm-lynx.h 2001/08/24 12:16:33
@@ -17,5 +17,3 @@
    along with this program; if not, write to the Free Software
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
-
-#include <limits.h>		/* for INT_MIN */
Index: config/xm-nbsd.h
===================================================================
RCS file: /cvs/src/src/gdb/config/xm-nbsd.h,v
retrieving revision 1.2
diff -u -p -r1.2 xm-nbsd.h
--- config/xm-nbsd.h 2001/03/06 08:21:20 1.2
+++ config/xm-nbsd.h 2001/08/24 12:16:33
@@ -22,10 +22,6 @@
    define on some systems. */
 #include <sys/param.h>
 
-/* We have to include these files now, so that GDB will not make
-   competing definitions in defs.h.  */
-#include <limits.h>
-
 #include <machine/endian.h>
 #if BYTE_ORDER == BIG_ENDIAN
 #define HOST_BYTE_ORDER BIG_ENDIAN
Index: config/xm-sysv4.h
===================================================================
RCS file: /cvs/src/src/gdb/config/xm-sysv4.h,v
retrieving revision 1.4
diff -u -p -r1.4 xm-sysv4.h
--- config/xm-sysv4.h 2001/07/23 19:21:53 1.4
+++ config/xm-sysv4.h 2001/08/24 12:16:33
@@ -27,7 +27,3 @@
 /* SVR4 is a derivative of System V Release 3 (USG) */
 
 #define USG
-
-/* We have to include these files now, so that GDB will not make
-   competing definitions in defs.h.  */
-#include <limits.h>
Index: config/i386/xm-i386aix.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/xm-i386aix.h,v
retrieving revision 1.2
diff -u -p -r1.2 xm-i386aix.h
--- config/i386/xm-i386aix.h 2001/07/23 19:21:54 1.2
+++ config/i386/xm-i386aix.h 2001/08/24 12:16:33
@@ -27,5 +27,3 @@
 
 #undef HAVE_TERMIO
 #define HAVE_SGTTY
-
-#include <limits.h>
Index: config/m68k/xm-dpx2.h
===================================================================
RCS file: /cvs/src/src/gdb/config/m68k/xm-dpx2.h,v
retrieving revision 1.2
diff -u -p -r1.2 xm-dpx2.h
--- config/m68k/xm-dpx2.h 2001/03/06 08:21:30 1.2
+++ config/m68k/xm-dpx2.h 2001/08/24 12:16:33
@@ -22,6 +22,3 @@
 
 #define HAVE_TERMIOS
 #define USG
-
-/* Avoid redefinition errors */
-#include <limits.h>

Re: [PATCH] Get rid of redundant inclusion of <limits.h>

[Andrew Cagney]

> Another step in reducing xm.h.  We already include <limits.h> from
> "defs.h".  No need to do it again from xm.h.  Tested on
> sparc-sun-solaris2.6 (which includes config/xm-sysv4.h).  Installed as
> an obvious fix (head only).

Just an aside, I'd not bother sitting on the other autoconf patches for 
two weeks.  I think they are ``in theory'' pretty obvious.  We're only 
going to find problem when they are committed.

Perhaphs instead, like Kevin was doing with K&R stuff, have a steady 
trickle.  If you're concerned about people being able to figure out 
which change broke what then I'd just be careful to only commit one per 
24 hours.  That way `-D 2001-MM-DD-gmt'(1) can quickly be used to flip 
between changes.

Keep it up!
	Andrew

(1) The snapshots use this.  They are always taken at exactly 00:00 UCT.