* [rfa] PPC/Linux native - don't use greg_t
@ 2001-07-05 14:40 Daniel Jacobowitz
2001-07-05 16:16 ` Kevin Buettner
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2001-07-05 14:40 UTC (permalink / raw)
To: gdb-patches
At least my installed systems don't actually define greg_t in headers any
more, unless you include <linux/elfcore.h> explicitly - which you can't,
since it conflicts with <sys/procfs.h>. I'm not convinced that that's
right, but since we are defining gdb_gregset_t to be an elf_gregset_t
already, using elf_greg_t makes sense to me. OK to commit?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
2001-07-05 Daniel Jacobowitz <drow@mvista.com>
* ppc-linux-nat.c (supply_gregset): Use elf_greg_t instead
of greg_t.
(fill_gregset): Likewise.
--- ppc-linux-nat.c.orig Thu Jul 5 14:34:58 2001
+++ ppc-linux-nat.c Thu Jul 5 14:34:29 2001
@@ -63,7 +63,7 @@
supply_gregset (gdb_gregset_t *gregsetp)
{
int regi;
- register greg_t *regp = (greg_t *) gregsetp;
+ register elf_greg_t *regp = (elf_greg_t *) gregsetp;
for (regi = 0; regi < 32; regi++)
supply_register (regi, (char *) (regp + regi));
@@ -76,7 +76,7 @@
fill_gregset (gdb_gregset_t *gregsetp, int regno)
{
int regi;
- greg_t *regp = (greg_t *) gregsetp;
+ elf_greg_t *regp = (elf_greg_t *) gregsetp;
#define COPY_REG(_idx_,_regi_) \
if ((regno == -1) || regno == _regi_) \
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [rfa] PPC/Linux native - don't use greg_t
2001-07-05 14:40 [rfa] PPC/Linux native - don't use greg_t Daniel Jacobowitz
@ 2001-07-05 16:16 ` Kevin Buettner
2001-07-05 16:22 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2001-07-05 16:16 UTC (permalink / raw)
To: Daniel Jacobowitz, gdb-patches
On Jul 5, 2:40pm, Daniel Jacobowitz wrote:
> At least my installed systems don't actually define greg_t in headers any
> more, unless you include <linux/elfcore.h> explicitly - which you can't,
> since it conflicts with <sys/procfs.h>. I'm not convinced that that's
> right, but since we are defining gdb_gregset_t to be an elf_gregset_t
> already, using elf_greg_t makes sense to me. OK to commit?
Yes; please commit your changes.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [rfa] PPC/Linux native - don't use greg_t
2001-07-05 16:16 ` Kevin Buettner
@ 2001-07-05 16:22 ` Daniel Jacobowitz
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2001-07-05 16:22 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
On Thu, Jul 05, 2001 at 04:15:08PM -0700, Kevin Buettner wrote:
> On Jul 5, 2:40pm, Daniel Jacobowitz wrote:
>
> > At least my installed systems don't actually define greg_t in headers any
> > more, unless you include <linux/elfcore.h> explicitly - which you can't,
> > since it conflicts with <sys/procfs.h>. I'm not convinced that that's
> > right, but since we are defining gdb_gregset_t to be an elf_gregset_t
> > already, using elf_greg_t makes sense to me. OK to commit?
>
> Yes; please commit your changes.
Thanks, committed.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-07-05 16:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-07-05 14:40 [rfa] PPC/Linux native - don't use greg_t Daniel Jacobowitz
2001-07-05 16:16 ` Kevin Buettner
2001-07-05 16:22 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox