* [RFA] testsuite/gdb.base/exprs.exp: Remove duplicate test
@ 2001-06-10 19:43 Michael Elizabeth Chastain
2001-06-11 8:08 ` Fernando Nasser
0 siblings, 1 reply; 3+ messages in thread
From: Michael Elizabeth Chastain @ 2001-06-10 19:43 UTC (permalink / raw)
To: gdb-patches
This is part of my quest to make all test names unique.
This patch removes a duplicate test from gdb.base/exprs.exp.
The duplicate test is:
print unsigned char == (~0) (print v_unsigned_char == ~0)
I also touched the copyright date. These are the only changes in
this patch.
I tested this on native Red Hat Linux 7 and native Solaris 2.8.
OK to apply?
Michael Elizabeth Chastain
<chastain@redhat.com>
"love without fear"
===
2001-06-10 Michael Chastain <chastain@redhat.com>
* gdb.base/exprs.exp: Remove a duplicate test.
===
Index: gdb/testsuite/gdb.base/exprs.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/exprs.exp,v
retrieving revision 1.5
diff -c -3 -p -r1.5 exprs.exp
*** gdb/testsuite/gdb.base/exprs.exp 2001/06/06 18:25:46 1.5
--- gdb/testsuite/gdb.base/exprs.exp 2001/06/11 00:24:07
***************
*** 1,4 ****
! # Copyright 1988, 1990, 1991, 1992, 1994, 1995, 1996, 1997, 1998, 2000
# Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
--- 1,4 ----
! # Copyright 1988, 1990, 1991, 1992, 1994, 1995, 1996, 1997, 1998, 2000, 2001
# Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
*************** test_expr "set variable v_unsigned_char=
*** 101,107 ****
# FIXME: gdb mishandles the cast (unsigned char) on the i960, so I've
# set up an expected failure for this case.
setup_xfail "i960-*-*" 1821
! test_expr "set variable v_unsigned_char=~0" "print v_unsigned_char == 0" "\\$\[0-9\]* = $false" "print v_unsigned_char == ~0" "\\$\[0-9\]* = $false" "print v_unsigned_char == (unsigned char)~0" "\\$\[0-9\]* = $true" "print v_unsigned_char == ~0" "\\$\[0-9\]* = $false" "print unsigned char == (~0)"
# FIXME: gdb mishandles the cast (unsigned char) on the i960, so I've
# set up an expected failure for this case.
setup_xfail "i960-*-*" 1821
--- 101,107 ----
# FIXME: gdb mishandles the cast (unsigned char) on the i960, so I've
# set up an expected failure for this case.
setup_xfail "i960-*-*" 1821
! test_expr "set variable v_unsigned_char=~0" "print v_unsigned_char == 0" "\\$\[0-9\]* = $false" "print v_unsigned_char == ~0" "\\$\[0-9\]* = $false" "print v_unsigned_char == (unsigned char)~0" "\\$\[0-9\]* = $true" "print unsigned char == (~0)"
# FIXME: gdb mishandles the cast (unsigned char) on the i960, so I've
# set up an expected failure for this case.
setup_xfail "i960-*-*" 1821
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] testsuite/gdb.base/exprs.exp: Remove duplicate test
2001-06-10 19:43 [RFA] testsuite/gdb.base/exprs.exp: Remove duplicate test Michael Elizabeth Chastain
@ 2001-06-11 8:08 ` Fernando Nasser
0 siblings, 0 replies; 3+ messages in thread
From: Fernando Nasser @ 2001-06-11 8:08 UTC (permalink / raw)
To: Michael Elizabeth Chastain; +Cc: gdb-patches
Yes, please check it in.
Fernando
Michael Elizabeth Chastain wrote:
>
> This is part of my quest to make all test names unique.
>
> This patch removes a duplicate test from gdb.base/exprs.exp.
> The duplicate test is:
>
> print unsigned char == (~0) (print v_unsigned_char == ~0)
>
> I also touched the copyright date. These are the only changes in
> this patch.
>
> I tested this on native Red Hat Linux 7 and native Solaris 2.8.
>
> OK to apply?
>
> Michael Elizabeth Chastain
> <chastain@redhat.com>
> "love without fear"
>
> ===
>
> 2001-06-10 Michael Chastain <chastain@redhat.com>
>
> * gdb.base/exprs.exp: Remove a duplicate test.
>
> ===
>
> Index: gdb/testsuite/gdb.base/exprs.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/exprs.exp,v
> retrieving revision 1.5
> diff -c -3 -p -r1.5 exprs.exp
> *** gdb/testsuite/gdb.base/exprs.exp 2001/06/06 18:25:46 1.5
> --- gdb/testsuite/gdb.base/exprs.exp 2001/06/11 00:24:07
> ***************
> *** 1,4 ****
> ! # Copyright 1988, 1990, 1991, 1992, 1994, 1995, 1996, 1997, 1998, 2000
> # Free Software Foundation, Inc.
>
> # This program is free software; you can redistribute it and/or modify
> --- 1,4 ----
> ! # Copyright 1988, 1990, 1991, 1992, 1994, 1995, 1996, 1997, 1998, 2000, 2001
> # Free Software Foundation, Inc.
>
> # This program is free software; you can redistribute it and/or modify
> *************** test_expr "set variable v_unsigned_char=
> *** 101,107 ****
> # FIXME: gdb mishandles the cast (unsigned char) on the i960, so I've
> # set up an expected failure for this case.
> setup_xfail "i960-*-*" 1821
> ! test_expr "set variable v_unsigned_char=~0" "print v_unsigned_char == 0" "\\$\[0-9\]* = $false" "print v_unsigned_char == ~0" "\\$\[0-9\]* = $false" "print v_unsigned_char == (unsigned char)~0" "\\$\[0-9\]* = $true" "print v_unsigned_char == ~0" "\\$\[0-9\]* = $false" "print unsigned char == (~0)"
> # FIXME: gdb mishandles the cast (unsigned char) on the i960, so I've
> # set up an expected failure for this case.
> setup_xfail "i960-*-*" 1821
> --- 101,107 ----
> # FIXME: gdb mishandles the cast (unsigned char) on the i960, so I've
> # set up an expected failure for this case.
> setup_xfail "i960-*-*" 1821
> ! test_expr "set variable v_unsigned_char=~0" "print v_unsigned_char == 0" "\\$\[0-9\]* = $false" "print v_unsigned_char == ~0" "\\$\[0-9\]* = $false" "print v_unsigned_char == (unsigned char)~0" "\\$\[0-9\]* = $true" "print unsigned char == (~0)"
> # FIXME: gdb mishandles the cast (unsigned char) on the i960, so I've
> # set up an expected failure for this case.
> setup_xfail "i960-*-*" 1821
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] testsuite/gdb.base/exprs.exp: Remove duplicate test
@ 2001-06-11 9:12 Michael Elizabeth Chastain
0 siblings, 0 replies; 3+ messages in thread
From: Michael Elizabeth Chastain @ 2001-06-11 9:12 UTC (permalink / raw)
To: chastain, fnasser; +Cc: gdb-patches
Committed. Nine files done, 25 to go.
Fernando filled me in on a bit of the history about where the
duplicate test came from.
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-06-11 9:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-06-10 19:43 [RFA] testsuite/gdb.base/exprs.exp: Remove duplicate test Michael Elizabeth Chastain
2001-06-11 8:08 ` Fernando Nasser
2001-06-11 9:12 Michael Elizabeth Chastain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox