Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Deephanphongs <deephan@telocity.com>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Stale FIXME
Date: Tue, 22 May 2001 00:24:00 -0000	[thread overview]
Message-ID: <20010522031008.A30509@llamedos.org> (raw)

There appears to be a stale FIXME in main.c - it warns about the
argument after the program-name (corearg):
  /* FIXME: The documentation says this can be a "ProcID". as well. */

GDB /does/ treat the corearg as a PID, though.
First it tries to open corearg as a core-file.  If that fails, it attempts
to use it as a PID (main.c:615-623).

----- Changelog Entry ------
2001-05-22  David Deephanphongs  <david@llamedos.org>

	* main.c: Removed stale FIXME - GDB /does/ try to use the second
	argument as a PID if the arg. isn't a core file.

----- End Changelog Entry -----

----- Patch -----
diff -c3p gdb/main.c gdb-new/main.c
*** gdb/main.c	Mon May  7 15:03:11 2001
--- gdb-new/main.c	Tue May 22 02:53:54 2001
*************** extern int gdbtk_test (char *);
*** 473,479 ****
  	  execarg = argv[optind];
  	  break;
  	case 2:
- 	  /* FIXME: The documentation says this can be a "ProcID". as well. */
  	  corearg = argv[optind];
  	  break;
  	case 3:
--- 473,478 ----
------ End Patch ------

-- 
Brother Preptil, the master of the music, had described Brutha's voice as
putting him in mind of a disappointed vulture arriving too late at the dead
donkey.
        -- (Terry Pratchett, Small Gods)


             reply	other threads:[~2001-05-22  0:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-22  0:24 David Deephanphongs [this message]
2001-05-23 16:03 ` Fernando Nasser
2001-06-06 14:46   ` Elena Zannoni
2001-06-06 15:02     ` Fernando Nasser
2001-06-06 18:42       ` David Deephanphongs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010522031008.A30509@llamedos.org \
    --to=deephan@telocity.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox