From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Deephanphongs To: gdb-patches@sources.redhat.com Subject: [PATCH] Stale FIXME Date: Tue, 22 May 2001 00:24:00 -0000 Message-id: <20010522031008.A30509@llamedos.org> X-SW-Source: 2001-05/msg00412.html There appears to be a stale FIXME in main.c - it warns about the argument after the program-name (corearg): /* FIXME: The documentation says this can be a "ProcID". as well. */ GDB /does/ treat the corearg as a PID, though. First it tries to open corearg as a core-file. If that fails, it attempts to use it as a PID (main.c:615-623). ----- Changelog Entry ------ 2001-05-22 David Deephanphongs * main.c: Removed stale FIXME - GDB /does/ try to use the second argument as a PID if the arg. isn't a core file. ----- End Changelog Entry ----- ----- Patch ----- diff -c3p gdb/main.c gdb-new/main.c *** gdb/main.c Mon May 7 15:03:11 2001 --- gdb-new/main.c Tue May 22 02:53:54 2001 *************** extern int gdbtk_test (char *); *** 473,479 **** execarg = argv[optind]; break; case 2: - /* FIXME: The documentation says this can be a "ProcID". as well. */ corearg = argv[optind]; break; case 3: --- 473,478 ---- ------ End Patch ------ -- Brother Preptil, the master of the music, had described Brutha's voice as putting him in mind of a disappointed vulture arriving too late at the dead donkey. -- (Terry Pratchett, Small Gods)