From: Eli Zaretskii <eliz@delorie.com>
To: kettenis@wins.uva.nl
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH, RFC]: Change order of setting i386 debug registers
Date: Sat, 31 Mar 2001 08:23:00 -0000 [thread overview]
Message-ID: <200103311623.LAA22298@indy.delorie.com> (raw)
In-Reply-To: <200103311556.f2VFu2O00222@delius.kettenis.local>
> Date: Sat, 31 Mar 2001 17:56:02 +0200
> From: Mark Kettenis <kettenis@wins.uva.nl>
>
> FreeBSD/i386 does some strict checking on the debug registers before
> setting them. This conflicts a bit with the order in which the code
> in i386-nat.c tries to set the registers. The attached patch fixes
> these problems by changing the order in which we modify the
> registers. Instead of enabling an address register before storing the
> proper address in it, after the patch, we will first store the address
> and then enable the address register. This seems more correct to me.
You are right; it was my mistake not to do it that way in the first
place.
> Any objections to checking this in?
Please do.
prev parent reply other threads:[~2001-03-31 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-31 7:56 Mark Kettenis
2001-03-31 8:23 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200103311623.LAA22298@indy.delorie.com \
--to=eliz@delorie.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@wins.uva.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox