From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Zaretskii To: kettenis@wins.uva.nl Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH, RFC]: Change order of setting i386 debug registers Date: Sat, 31 Mar 2001 08:23:00 -0000 Message-id: <200103311623.LAA22298@indy.delorie.com> References: <200103311556.f2VFu2O00222@delius.kettenis.local> X-SW-Source: 2001-03/msg00577.html > Date: Sat, 31 Mar 2001 17:56:02 +0200 > From: Mark Kettenis > > FreeBSD/i386 does some strict checking on the debug registers before > setting them. This conflicts a bit with the order in which the code > in i386-nat.c tries to set the registers. The attached patch fixes > these problems by changing the order in which we modify the > registers. Instead of enabling an address register before storing the > proper address in it, after the patch, we will first store the address > and then enable the address register. This seems more correct to me. You are right; it was my mistake not to do it that way in the first place. > Any objections to checking this in? Please do.