From: Christopher Faylor <cgf@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] gdb/win32-nat.c: check for NULL before calling strtoul
Date: Sun, 18 Mar 2001 12:46:00 -0000 [thread overview]
Message-ID: <20010318141134.P12880@redhat.com> (raw)
In-Reply-To: <200103180752.XAA02531@bosch.cygnus.com>
On Sat, Mar 17, 2001 at 11:52:23PM -0800, Michael Elizabeth Chastain wrote:
>This patch fixes PR gdb/43, a coding error in child_attach. Cygwin's
>implementation of strtoul dumps core if the input pointer is NULL.
>This means gdb dumps core on a plain "attach" command with no arguments.
>
>This fix enables the test script gdb.base/default.exp to run to
>completion.
>
>I tested this on Windows 2000 Professional + cygwin 1.1.8. I gave a
>plain "attach" command by hand and also ran gdb.base/default.exp.
>
>OK to apply?
Yes.
Thanks,
cgf
>2001-03-17 Michael Chastain <chastain@redhat.com>
>
> * win32-nat.c (child_attach): check args for NULL before passing
> to strtoul. This fixes PR gdb/43.
prev parent reply other threads:[~2001-03-18 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-17 23:52 Michael Elizabeth Chastain
2001-03-18 12:46 ` Christopher Faylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010318141134.P12880@redhat.com \
--to=cgf@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox