From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Faylor To: gdb-patches@sources.redhat.com Subject: Re: [RFA] gdb/win32-nat.c: check for NULL before calling strtoul Date: Sun, 18 Mar 2001 12:46:00 -0000 Message-id: <20010318141134.P12880@redhat.com> References: <200103180752.XAA02531@bosch.cygnus.com> X-SW-Source: 2001-03/msg00334.html On Sat, Mar 17, 2001 at 11:52:23PM -0800, Michael Elizabeth Chastain wrote: >This patch fixes PR gdb/43, a coding error in child_attach. Cygwin's >implementation of strtoul dumps core if the input pointer is NULL. >This means gdb dumps core on a plain "attach" command with no arguments. > >This fix enables the test script gdb.base/default.exp to run to >completion. > >I tested this on Windows 2000 Professional + cygwin 1.1.8. I gave a >plain "attach" command by hand and also ran gdb.base/default.exp. > >OK to apply? Yes. Thanks, cgf >2001-03-17 Michael Chastain > > * win32-nat.c (child_attach): check args for NULL before passing > to strtoul. This fixes PR gdb/43.