From: Richard Earnshaw <rearnsha@arm.com>
To: DJ Delorie <dj@redhat.com>
Cc: Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com
Subject: Re: [patch] add trace capabilities to arm sim
Date: Mon, 26 Feb 2001 11:02:00 -0000 [thread overview]
Message-ID: <200102261902.TAA18797@cam-mail2.cambridge.arm.com> (raw)
In-Reply-To: <200102261856.NAA01929@greed.delorie.com>
dj@redhat.com said:
> > + if (!do_tracing)
> > + return;
>
> > Shouldn't this be the first thing you check?
> Either way worked for me, but I can make it first.
I'd go one step further. Move the check to the caller side.
R.
next prev parent reply other threads:[~2001-02-26 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200102240025.TAA28612@greed.delorie.com>
2001-02-26 10:40 ` Richard Earnshaw
2001-02-26 10:57 ` DJ Delorie
2001-02-26 11:02 ` Richard Earnshaw [this message]
2001-02-26 11:12 ` DJ Delorie
2001-02-27 1:47 ` Richard Earnshaw
[not found] <o53dd1w76u.fsf@toenail.toronto.redhat.com>
2001-02-27 6:26 ` Richard Earnshaw
2001-02-27 7:08 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200102261902.TAA18797@cam-mail2.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=dj@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox