From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Earnshaw To: DJ Delorie Cc: Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com Subject: Re: [patch] add trace capabilities to arm sim Date: Mon, 26 Feb 2001 11:02:00 -0000 Message-id: <200102261902.TAA18797@cam-mail2.cambridge.arm.com> References: <200102261856.NAA01929@greed.delorie.com> X-SW-Source: 2001-02/msg00468.html dj@redhat.com said: > > + if (!do_tracing) > > + return; > > > Shouldn't this be the first thing you check? > Either way worked for me, but I can make it first. I'd go one step further. Move the check to the caller side. R.