Re: [RFA] New gnats #14 bug fix

Re: [RFA] New gnats #14 bug fix

[Michael Elizabeth Chastain]

I proofread this patch.  I tested it on Solaris 2.6 with gcc cvs
gcc-3_0-branch dated 2001-02-19 and gdb cvs dated 2001-02-19.  I found
no problems.

Recommended for approval (but not approved, I don't have that authority).

Michael

Re: [RFA] New gnats #14 bug fix

[Michael Elizabeth Chastain]

> Michael, you have his patch in your sandbox already, can you please
> check it in (after removing the "bt" and adding the comment)?

Done, as specified.  I re-tested after removing the "bt".

John, you can close the PR whenever you feel comfortable.

Michael

Re: [RFA] New gnats #14 bug fix

[John R. Moore]

This time, we pulled the hpux fix for this into all platforms.
This was tested with cvs version of gcc (2.97) on linux-2.4.

Changelog:

2001-02-19	John Moore	<jmoore@redhat.com>

	* gdb.base/commands.exp (infrun_breakpoint_command_test):
	Converted HPUX fix for non-expected items following multiple
	step commands into general solution for all platforms.

Index: commands.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/commands.exp,v
retrieving revision 1.6
diff -p -u -w -r1.6 gdb/testsuite/gdb.base/commands.exp
--- commands.exp	2000/10/24 18:36:32	1.6
+++ commands.exp	2001/02/19 16:50:30
@@ -202,26 +202,9 @@ proc infrun_breakpoint_command_test {} {
     gdb_test "step\nstep\nstep\nstep\nbt\nend" "" \
 	"commands in infrun_breakpoint_command_test #2"
 
-    if { [istarget "hppa*-hp-hpux*"] } {
 	gdb_test "continue" \
 		"Continuing.*.*.*Breakpoint \[0-9\]*, factorial \\(value=5\\).*at.*\[0-9\]*\[      \]*if \\(value > 1\\) \{.*\[0-9\]*\[      \]*value \\*= factorial \\(value - 1\\);.*" \
 		"continue in infrun_breakpoint_command_test"
-    } else {
-	gdb_test "continue" \
-		"Breakpoint \[0-9\]*, factorial \\(value=5\\).*at.*
-\[0-9\]*\[ 	\]*if \\(value > 1\\) \{.*
-\[0-9\]*\[ 	\]*value \\*= factorial \\(value - 1\\);.*
-factorial \\(value=4\\) at.*\[0-9\]*\[ 	\]*if \\(value > 1\\) \{.*
-\[0-9\]*\[ 	\]*value \\*= factorial \\(value - 1\\);.*
-factorial \\(value=3\\) at .*
-\[0-9\]*\[ 	\]*if \\(value > 1\\) \{.*
-#0  factorial \\(value=3\\).*
-#1  \[0-9a-fx\]* in factorial \\(value=4\\).*
-#2  \[0-9a-fx\]* in factorial \\(value=5\\).*
-#3  \[0-9a-fx\]* in factorial \\(value=6\\).*
-#4  \[0-9a-fx\]* in main \\(.*\\).*" \
-		"continue in infrun_breakpoint_command_test";
-    }
 
     gdb_stop_suppressing_tests;
 }

Re: [RFA] New gnats #14 bug fix

[Fernando Nasser]

Nice work John.

But before checking this in, please remove the "bt" command from the
list of commands sent to gdb and add a comment after the line 
   # Test that we can run the inferior from breakpoint commands.
stating that the expected behavior is that only the first "step" shall
be executed.

Thanks for the fix.

Fernando


"John R. Moore" wrote:
> 
> This time, we pulled the hpux fix for this into all platforms.
> This was tested with cvs version of gcc (2.97) on linux-2.4.
> 
> Changelog:
> 
> 2001-02-19      John Moore      <jmoore@redhat.com>
> 
>         * gdb.base/commands.exp (infrun_breakpoint_command_test):
>         Converted HPUX fix for non-expected items following multiple
>         step commands into general solution for all platforms.
> 
> Index: commands.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/commands.exp,v
> retrieving revision 1.6
> diff -p -u -w -r1.6 gdb/testsuite/gdb.base/commands.exp
> --- commands.exp        2000/10/24 18:36:32     1.6
> +++ commands.exp        2001/02/19 16:50:30
> @@ -202,26 +202,9 @@ proc infrun_breakpoint_command_test {} {
>      gdb_test "step\nstep\nstep\nstep\nbt\nend" "" \
>         "commands in infrun_breakpoint_command_test #2"
> 
> -    if { [istarget "hppa*-hp-hpux*"] } {
>         gdb_test "continue" \
>                 "Continuing.*.*.*Breakpoint \[0-9\]*, factorial \\(value=5\\).*at.*\[0-9\]*\[      \]*if \\(value > 1\\) \{.*\[0-9\]*\[      \]*value \\*= factorial \\(value - 1\\);.*" \
>                 "continue in infrun_breakpoint_command_test"
> -    } else {
> -       gdb_test "continue" \
> -               "Breakpoint \[0-9\]*, factorial \\(value=5\\).*at.*
> -\[0-9\]*\[     \]*if \\(value > 1\\) \{.*
> -\[0-9\]*\[     \]*value \\*= factorial \\(value - 1\\);.*
> -factorial \\(value=4\\) at.*\[0-9\]*\[         \]*if \\(value > 1\\) \{.*
> -\[0-9\]*\[     \]*value \\*= factorial \\(value - 1\\);.*
> -factorial \\(value=3\\) at .*
> -\[0-9\]*\[     \]*if \\(value > 1\\) \{.*
> -#0  factorial \\(value=3\\).*
> -#1  \[0-9a-fx\]* in factorial \\(value=4\\).*
> -#2  \[0-9a-fx\]* in factorial \\(value=5\\).*
> -#3  \[0-9a-fx\]* in factorial \\(value=6\\).*
> -#4  \[0-9a-fx\]* in main \\(.*\\).*" \
> -               "continue in infrun_breakpoint_command_test";
> -    }
> 
>      gdb_stop_suppressing_tests;
>  }

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9

Re: [RFA] New gnats #14 bug fix

[Fernando Nasser]

I just realized that John does not have check-in-after-approval yet.

Michael, you have his patch in your sandbox already, can you please
check it in (after removing the "bt" and adding the comment)?

Thanks,
Fernando 

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9