* [RFA] runto.change: fix some more runto's in gdb.c++
@ 2001-02-18 11:14 Michael Elizabeth Chastain
2001-02-18 11:52 ` Fernando Nasser
0 siblings, 1 reply; 2+ messages in thread
From: Michael Elizabeth Chastain @ 2001-02-18 11:14 UTC (permalink / raw)
To: gdb-patches
This is Sunday Project patch #4.
This is the same fix as patch #3, applied to some more files:
s/runto foo(void)/runto foo/
Again, the names used are not overloaded or anything; they are just
ordinary marker names.
This does not change the FAIL count significantly. After applying this
patch, the test scripts get further, and then FAIL due to other
g++/gdb issues.
I tested this with v2 and v3 versions of g++ on Red Hat Linux 7 native
and Solaris 2.6 native. I inspected gdb.log and verified that the
each 'runto' command is working properly.
OK to apply?
Michael Elizabeth Chastain
<chastain@redhat.com>
"love without fear"
2001-02-18 Michael Chastain <chastain@redhat.com>
* gdb.c++/classes.exp (do_tests): Change runto statements
from "runto 'foo(void)'" to "runto 'foo'". This makes the
statements demangler agnostic.
* gdb.c++/virtfunc.exp (do_tests): Likewise.
(gdb_virtfunc_restart): Likewise.
Index: gdb/testsuite/gdb.c++/classes.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/classes.exp,v
retrieving revision 1.4
diff -c -3 -p -r1.4 classes.exp
*** gdb/testsuite/gdb.c++/classes.exp 2000/08/02 22:10:10 1.4
--- gdb/testsuite/gdb.c++/classes.exp 2001/02/18 18:13:03
***************
*** 1,4 ****
! # Copyright (C) 1992, 1994, 1995, 1997, 1999 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright (C) 1992, 1994, 1995, 1997, 1999, 2001 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
*************** proc do_tests {} {
*** 826,832 ****
test_ptype_class_objects
! if [ runto 'inheritance2(void)' ] then {
test_non_inherited_member_access
test_wrong_class_members
test_nonexistent_members
--- 826,832 ----
test_ptype_class_objects
! if [ runto 'inheritance2' ] then {
test_non_inherited_member_access
test_wrong_class_members
test_nonexistent_members
Index: gdb/testsuite/gdb.c++/virtfunc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/virtfunc.exp,v
retrieving revision 1.1.1.5
diff -c -3 -p -r1.1.1.5 virtfunc.exp
*** gdb/testsuite/gdb.c++/virtfunc.exp 1999/12/07 03:56:17 1.1.1.5
--- gdb/testsuite/gdb.c++/virtfunc.exp 2001/02/18 18:13:04
***************
*** 1,4 ****
! # Copyright (C) 1992, 1994, 1997, 1999 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright (C) 1992, 1994, 1997, 1999, 2001 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
*************** proc gdb_virtfunc_restart {} {
*** 60,66 ****
gdb_exit;
gdb_start;
gdb_virtfunc_init;
! runto 'test_calls(void)';
}
#
--- 60,66 ----
gdb_exit;
gdb_start;
gdb_virtfunc_init;
! runto 'test_calls';
}
#
*************** proc do_tests {} {
*** 892,898 ****
test_ptype_of_classes
! if [ runto 'test_calls(void)' ] then {
test_virtual_calls
}
}
--- 892,898 ----
test_ptype_of_classes
! if [ runto 'test_calls' ] then {
test_virtual_calls
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RFA] runto.change: fix some more runto's in gdb.c++
2001-02-18 11:14 [RFA] runto.change: fix some more runto's in gdb.c++ Michael Elizabeth Chastain
@ 2001-02-18 11:52 ` Fernando Nasser
0 siblings, 0 replies; 2+ messages in thread
From: Fernando Nasser @ 2001-02-18 11:52 UTC (permalink / raw)
To: Michael Elizabeth Chastain; +Cc: gdb-patches
Michael Elizabeth Chastain wrote:
>
> This is Sunday Project patch #4.
>
> This is the same fix as patch #3, applied to some more files:
>
> s/runto foo(void)/runto foo/
>
> Again, the names used are not overloaded or anything; they are just
> ordinary marker names.
>
> This does not change the FAIL count significantly. After applying this
> patch, the test scripts get further, and then FAIL due to other
> g++/gdb issues.
>
> I tested this with v2 and v3 versions of g++ on Red Hat Linux 7 native
> and Solaris 2.6 native. I inspected gdb.log and verified that the
> each 'runto' command is working properly.
>
> OK to apply?
>
Sure.
Thanks.
Fernando
> Michael Elizabeth Chastain
> <chastain@redhat.com>
> "love without fear"
>
> 2001-02-18 Michael Chastain <chastain@redhat.com>
>
> * gdb.c++/classes.exp (do_tests): Change runto statements
> from "runto 'foo(void)'" to "runto 'foo'". This makes the
> statements demangler agnostic.
> * gdb.c++/virtfunc.exp (do_tests): Likewise.
> (gdb_virtfunc_restart): Likewise.
>
> Index: gdb/testsuite/gdb.c++/classes.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/classes.exp,v
> retrieving revision 1.4
> diff -c -3 -p -r1.4 classes.exp
> *** gdb/testsuite/gdb.c++/classes.exp 2000/08/02 22:10:10 1.4
> --- gdb/testsuite/gdb.c++/classes.exp 2001/02/18 18:13:03
> ***************
> *** 1,4 ****
> ! # Copyright (C) 1992, 1994, 1995, 1997, 1999 Free Software Foundation, Inc.
>
> # This program is free software; you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> --- 1,4 ----
> ! # Copyright (C) 1992, 1994, 1995, 1997, 1999, 2001 Free Software Foundation, Inc.
>
> # This program is free software; you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> *************** proc do_tests {} {
> *** 826,832 ****
>
> test_ptype_class_objects
>
> ! if [ runto 'inheritance2(void)' ] then {
> test_non_inherited_member_access
> test_wrong_class_members
> test_nonexistent_members
> --- 826,832 ----
>
> test_ptype_class_objects
>
> ! if [ runto 'inheritance2' ] then {
> test_non_inherited_member_access
> test_wrong_class_members
> test_nonexistent_members
> Index: gdb/testsuite/gdb.c++/virtfunc.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/virtfunc.exp,v
> retrieving revision 1.1.1.5
> diff -c -3 -p -r1.1.1.5 virtfunc.exp
> *** gdb/testsuite/gdb.c++/virtfunc.exp 1999/12/07 03:56:17 1.1.1.5
> --- gdb/testsuite/gdb.c++/virtfunc.exp 2001/02/18 18:13:04
> ***************
> *** 1,4 ****
> ! # Copyright (C) 1992, 1994, 1997, 1999 Free Software Foundation, Inc.
>
> # This program is free software; you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> --- 1,4 ----
> ! # Copyright (C) 1992, 1994, 1997, 1999, 2001 Free Software Foundation, Inc.
>
> # This program is free software; you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> *************** proc gdb_virtfunc_restart {} {
> *** 60,66 ****
> gdb_exit;
> gdb_start;
> gdb_virtfunc_init;
> ! runto 'test_calls(void)';
> }
>
> #
> --- 60,66 ----
> gdb_exit;
> gdb_start;
> gdb_virtfunc_init;
> ! runto 'test_calls';
> }
>
> #
> *************** proc do_tests {} {
> *** 892,898 ****
>
> test_ptype_of_classes
>
> ! if [ runto 'test_calls(void)' ] then {
> test_virtual_calls
> }
> }
> --- 892,898 ----
>
> test_ptype_of_classes
>
> ! if [ runto 'test_calls' ] then {
> test_virtual_calls
> }
> }
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-02-18 11:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-02-18 11:14 [RFA] runto.change: fix some more runto's in gdb.c++ Michael Elizabeth Chastain
2001-02-18 11:52 ` Fernando Nasser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox