Re: RFA: handle sparse register sets in Insight register window

Re: RFA: handle sparse register sets in Insight register window

[James Ingham]

Jim,

This looks okay, but in half the uses you only want the names of the
register, so wouldn't it be better to add a flag to gdb_regnames to
print out the index, so:

gdb_regnames

just prints out the names, and

gdb_regnames -index

prints out the list of pairs?

This would be simpler and faster on the Tcl end.  You can check for
the flag in gdb_regnames, and use the last argument of
map_arg_registers to pass in the value.

Jim

Re: RFA: handle sparse register sets in Insight register window

[James Ingham]

Jim,

This looks okay, but in half the uses you only want the names of the
register, so wouldn't it be better to add a flag to gdb_regnames to
print out the index, so:

gdb_regnames

just prints out the names, and

gdb_regnames -index

prints out the list of pairs?

This would be simpler and faster on the Tcl end.  You can check for
the flag in gdb_regnames, and use the last argument of
map_arg_registers to pass in the value.

Jim