Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* RFA: gdbarch_free
@ 2000-04-01  0:00 Jim Blandy
  2000-02-28 17:03 ` Andrew Cagney
  0 siblings, 1 reply; 4+ messages in thread
From: Jim Blandy @ 2000-04-01  0:00 UTC (permalink / raw)
  To: gdb-patches

There are no uses for this yet, except in some code that's not ready
for release yet.

2000-02-28  Jim Blandy  <jimb@redhat.com>

	* gdbarch.sh: Emit a definition and declaration for gdbarch_free,
 	a companion to gdbarch_alloc, which allows a gdbarch init function
 	to free partially-built gdbarch structures.
	* gdbarch.c, gdbarch.h: Regenerated.

Index: gdb/gdbarch.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.sh,v
retrieving revision 1.4
diff -c -r1.4 gdbarch.sh
*** gdbarch.sh	2000/02/23 02:42:40	1.4
--- gdbarch.sh	2000/02/28 23:01:13
***************
*** 512,517 ****
--- 512,521 ----
  extern struct gdbarch *gdbarch_alloc (const struct gdbarch_info *info, struct gdbarch_tdep *tdep);
  
  
+ /* Helper function.  Free a partially-constructed \`\`struct gdbarch''.  */
+ extern void gdbarch_free (struct gdbarch *);
+ 
+ 
  /* Helper function. Force an update of the current architecture.  Used
     by legacy targets that have added their own target specific
     architecture manipulation commands.
***************
*** 958,963 ****
--- 962,984 ----
    /* gdbarch_alloc() */
  
    return gdbarch;
+ }
+ EOF
+ 
+ # Free a gdbarch struct.
+ echo ""
+ echo ""
+ cat <<EOF
+ /* Free a gdbarch struct.  This should never happen in normal
+    operation --- once you've created a gdbarch, you keep it around.
+    However, if an architecture's init function encounters an error
+    building the structure, it may need to clean up a partially
+    constructed gdbarch.  */
+ void
+ gdbarch_free (struct gdbarch *arch)
+ {
+   /* At the moment, this is trivial.  */
+   free (arch);
  }
  EOF
  
Index: gdb/gdbarch.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.c,v
retrieving revision 1.3
diff -c -r1.3 gdbarch.c
*** gdbarch.c	2000/02/22 19:17:27	1.3
--- gdbarch.c	2000/02/28 23:01:16
***************
*** 357,362 ****
--- 357,375 ----
  }
  
  
+ /* Free a gdbarch struct.  This should never happen in normal
+    operation --- once you've created a gdbarch, you keep it around.
+    However, if an architecture's init function encounters an error
+    building the structure, it may need to clean up a partially
+    constructed gdbarch.  */
+ void
+ gdbarch_free (struct gdbarch *arch)
+ {
+   /* At the moment, this is trivial.  */
+   free (arch);
+ }
+ 
+ 
  /* Ensure that all values in a GDBARCH are reasonable. */
  
  static void
Index: gdb/gdbarch.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.h,v
retrieving revision 1.3
diff -c -r1.3 gdbarch.h
*** gdbarch.h	2000/02/23 02:42:40	1.3
--- gdbarch.h	2000/02/28 23:01:18
***************
*** 909,914 ****
--- 909,918 ----
  extern struct gdbarch *gdbarch_alloc (const struct gdbarch_info *info, struct gdbarch_tdep *tdep);
  
  
+ /* Helper function.  Free a partially-constructed ``struct gdbarch''.  */
+ extern void gdbarch_free (struct gdbarch *);
+ 
+ 
  /* Helper function. Force an update of the current architecture.  Used
     by legacy targets that have added their own target specific
     architecture manipulation commands.
From jtc@redback.com Sat Apr 01 00:00:00 2000
From: jtc@redback.com (J.T. Conklin)
To: gdb-patches@sourceware.cygnus.com
Subject: RFA: list which remote protocol commands are required
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <5md7opufwl.fsf@jtc.redbacknetworks.com>
X-SW-Source: 2000-q1/msg00843.html
Content-length: 9902

I submit the enclosed patch for approval.  The existing documentation
labled some remote protocol commands as optional, while in fact most
commands are.  This patch removes the "optional" tag from the table
of commands, and explicitly lists the required commands.

        --jtc

2000-03-20  J.T. Conklin  <jtc@redback.com>

	* gdb.texinfo: Clarify which remote debug protocol commands are
 	required and which are optional.

Index: gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.4
diff -c -r1.4 gdb.texinfo
*** gdb.texinfo	2000/03/20 22:51:36	1.4
--- gdb.texinfo	2000/03/21 03:59:16
***************
*** 8835,8840 ****
--- 8835,8844 ----
  protocol.  A newer @value{GDBN} can tell if a packet is supported based
  on that response.
  
+ A stub is required to support the @samp{g}, @samp{G}, @samp{m}, @samp{M}, 
+ @samp{c}, and @samp{s} @var{command}s.  All other @var{command}s are 
+ optional.
+ 
  Below is a complete list of all currently defined @var{command}s and
  their corresponding response @var{data}:
  
***************
*** 8843,8849 ****
  @tab Request
  @tab Description
  
! @item extended ops @emph{(optional)}
  @tab @code{!}
  @tab
  Use the extended remote protocol.  Sticky---only needs to be set once.
--- 8847,8853 ----
  @tab Request
  @tab Description
  
! @item extended ops
  @tab @code{!}
  @tab
  Use the extended remote protocol.  Sticky---only needs to be set once.
***************
*** 8869,8875 ****
  @tab @code{a}
  @tab Reserved for future use 
  
! @item set program arguments @strong{(reserved)} @emph{(optional)}
  @tab @code{A}@var{arglen}@code{,}@var{argnum}@code{,}@var{arg}@code{,...}
  @tab
  Initialized @samp{argv[]} array passed into program. @var{arglen}
--- 8873,8879 ----
  @tab @code{a}
  @tab Reserved for future use 
  
! @item set program arguments @strong{(reserved)}
  @tab @code{A}@var{arglen}@code{,}@var{argnum}@code{,}@var{arg}@code{,...}
  @tab
  Initialized @samp{argv[]} array passed into program. @var{arglen}
***************
*** 8909,8915 ****
  @tab reply
  @tab see below
  
! @item continue with signal @emph{(optional)}
  @tab @code{C}@var{sig}@code{;}@var{addr}
  @tab
  Continue with signal @var{sig} (hex signal number).  If
--- 8913,8919 ----
  @tab reply
  @tab see below
  
! @item continue with signal
  @tab @code{C}@var{sig}@code{;}@var{addr}
  @tab
  Continue with signal @var{sig} (hex signal number).  If
***************
*** 8923,8929 ****
  @tab
  toggle debug flag.
  
! @item detach @emph{(optional)}
  @tab @code{D}
  @tab
  Detach @value{GDBN} from the remote system.  Sent to the remote target before
--- 8927,8933 ----
  @tab
  toggle debug flag.
  
! @item detach
  @tab @code{D}
  @tab
  Detach @value{GDBN} from the remote system.  Sent to the remote target before
***************
*** 8980,8986 ****
  @tab @code{h}
  @tab Reserved for future use 
  
! @item set thread @emph{(optional)}
  @tab @code{H}@var{c}@var{t...}
  @tab
  Set thread for subsequent operations (@samp{m}, @samp{M}, @samp{g},
--- 8984,8990 ----
  @tab @code{h}
  @tab Reserved for future use 
  
! @item set thread 
  @tab @code{H}@var{c}@var{t...}
  @tab
  Set thread for subsequent operations (@samp{m}, @samp{M}, @samp{g},
***************
*** 9009,9022 ****
  @c                selected, sets the registers of the register block of
  @c                that thread; otherwise sets current registers.
  
! @item cycle step @strong{(draft)} @emph{(optional)}
  @tab @code{i}@var{addr}@code{,}@var{nnn}
  @tab
  Step the remote target by a single clock cycle.  If @code{,}@var{nnn} is
  present, cycle step @var{nnn} cycles.  If @var{addr} is present, cycle
  step starting at that address.
  
! @item signal then cycle step @strong{(reserved)} @emph{(optional)}
  @tab @code{I}
  @tab
  See @samp{i} and @samp{S} for likely syntax and semantics.
--- 9013,9026 ----
  @c                selected, sets the registers of the register block of
  @c                that thread; otherwise sets current registers.
  
! @item cycle step @strong{(draft)}
  @tab @code{i}@var{addr}@code{,}@var{nnn}
  @tab
  Step the remote target by a single clock cycle.  If @code{,}@var{nnn} is
  present, cycle step @var{nnn} cycles.  If @var{addr} is present, cycle
  step starting at that address.
  
! @item signal then cycle step @strong{(reserved)}
  @tab @code{I}
  @tab
  See @samp{i} and @samp{S} for likely syntax and semantics.
***************
*** 9029,9035 ****
  @tab @code{J}
  @tab Reserved for future use 
  
! @item kill request @emph{(optional)}
  @tab @code{k}
  @tab
  FIXME: @emph{There is no description of how operate when a specific
--- 9033,9039 ----
  @tab @code{J}
  @tab Reserved for future use 
  
! @item kill request
  @tab @code{k}
  @tab
  FIXME: @emph{There is no description of how operate when a specific
***************
*** 9099,9105 ****
  @tab return @var{r....}
  @tab The hex encoded value of the register in target byte order.
  
! @item write reg @emph{(optional)}
  @tab @code{P}@var{n...}@code{=}@var{r...}
  @tab
  Write register @var{n...} with value @var{r...}, which contains two hex
--- 9103,9109 ----
  @tab return @var{r....}
  @tab The hex encoded value of the register in target byte order.
  
! @item write reg
  @tab @code{P}@var{n...}@code{=}@var{r...}
  @tab
  Write register @var{n...} with value @var{r...}, which contains two hex
***************
*** 9111,9117 ****
  @tab reply @code{E}@var{NN}
  @tab for an error
  
! @item general query @emph{(optional)}
  @tab @code{q}@var{query}
  @tab
  Request info about @var{query}.  In general @value{GDBN} @var{query}'s
--- 9115,9121 ----
  @tab reply @code{E}@var{NN}
  @tab for an error
  
! @item general query
  @tab @code{q}@var{query}
  @tab
  Request info about @var{query}.  In general @value{GDBN} @var{query}'s
***************
*** 9129,9135 ****
  @tab reply @samp{}
  @tab Indicating an unrecognized @var{query}.
  
! @item general set @emph{(optional)}
  @tab @code{Q}@var{var}@code{=}@var{val}
  @tab
  Set value of @var{var} to @var{val}.  See @samp{q} for a discussing of
--- 9133,9139 ----
  @tab reply @samp{}
  @tab Indicating an unrecognized @var{query}.
  
! @item general set
  @tab @code{Q}@var{var}@code{=}@var{val}
  @tab
  Set value of @var{var} to @var{val}.  See @samp{q} for a discussing of
***************
*** 9140,9153 ****
  @tab
  Reset the entire system.
  
! @item remote restart @emph{(optional)}
  @tab @code{R}@var{XX}
  @tab
  Restart the remote server.  @var{XX} while needed has no clear
  definition.  FIXME: @emph{An example interaction explaining how this
  packet is used in extended-remote mode is needed}.
  
! @item step @emph{(optional)}
  @tab @code{s}@var{addr}
  @tab
  @var{addr} is address to resume.  If @var{addr} is omitted, resume at
--- 9144,9157 ----
  @tab
  Reset the entire system.
  
! @item remote restart
  @tab @code{R}@var{XX}
  @tab
  Restart the remote server.  @var{XX} while needed has no clear
  definition.  FIXME: @emph{An example interaction explaining how this
  packet is used in extended-remote mode is needed}.
  
! @item step
  @tab @code{s}@var{addr}
  @tab
  @var{addr} is address to resume.  If @var{addr} is omitted, resume at
***************
*** 9156,9162 ****
  @tab reply
  @tab see below
  
! @item step with signal @emph{(optional)}
  @tab @code{S}@var{sig}@code{;}@var{addr}
  @tab
  Like @samp{C} but step not continue.
--- 9160,9166 ----
  @tab reply
  @tab see below
  
! @item step with signal
  @tab @code{S}@var{sig}@code{;}@var{addr}
  @tab
  Like @samp{C} but step not continue.
***************
*** 9164,9177 ****
  @tab reply
  @tab see below
  
! @item search @emph{(optional)}
  @tab @code{t}@var{addr}@code{:}@var{PP}@code{,}@var{MM}
  @tab
  Search backwards starting at address @var{addr} for a match with pattern
  @var{PP} and mask @var{MM}.  @var{PP} and @var{MM} are 4
  bytes.  @var{addr} must be at least 3 digits.
  
! @item thread alive @emph{(optional)}
  @tab @code{T}@var{XX}
  @tab Find out if the thread XX is alive.
  @item
--- 9168,9181 ----
  @tab reply
  @tab see below
  
! @item search 
  @tab @code{t}@var{addr}@code{:}@var{PP}@code{,}@var{MM}
  @tab
  Search backwards starting at address @var{addr} for a match with pattern
  @var{PP} and mask @var{MM}.  @var{PP} and @var{MM} are 4
  bytes.  @var{addr} must be at least 3 digits.
  
! @item thread alive
  @tab @code{T}@var{XX}
  @tab Find out if the thread XX is alive.
  @item
***************
*** 9209,9215 ****
  @tab @code{x}
  @tab Reserved for future use 
  
! @item write mem (binary) @emph{(optional)}
  @tab @code{X}@var{addr}@code{,}@var{length}@var{:}@var{XX...}
  @tab
  @var{addr} is address, @var{length} is number of bytes, @var{XX...} is
--- 9213,9219 ----
  @tab @code{x}
  @tab Reserved for future use 
  
! @item write mem (binary)
  @tab @code{X}@var{addr}@code{,}@var{length}@var{:}@var{XX...}
  @tab
  @var{addr} is address, @var{length} is number of bytes, @var{XX...} is
***************
*** 9230,9241 ****
  @tab @code{Y}
  @tab Reserved for future use 
  
! @item remove break or watchpoint @strong{(draft)} @emph{(optional)}
  @tab @code{z}@var{t}@code{,}@var{addr}@code{,}@var{length}
  @tab
  See @samp{Z}.
  
! @item insert break or watchpoint @strong{(draft)} @emph{(optional)}
  @tab @code{Z}@var{t}@code{,}@var{addr}@code{,}@var{length}
  @tab
  @var{t} is type: @samp{0} - software breakpoint, @samp{1} - hardware
--- 9234,9245 ----
  @tab @code{Y}
  @tab Reserved for future use 
  
! @item remove break or watchpoint @strong{(draft)}
  @tab @code{z}@var{t}@code{,}@var{addr}@code{,}@var{length}
  @tab
  See @samp{Z}.
  
! @item insert break or watchpoint @strong{(draft)}
  @tab @code{Z}@var{t}@code{,}@var{addr}@code{,}@var{length}
  @tab
  @var{t} is type: @samp{0} - software breakpoint, @samp{1} - hardware


-- 
J.T. Conklin
RedBack Networks
From ac131313@cygnus.com Sat Apr 01 00:00:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: GDB Discussion <gdb@sourceware.cygnus.com>
Cc: GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: [MAINT] x86 maintainers .....
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <38BCA2B9.3BDE66AD@cygnus.com>
X-SW-Source: 2000-q1/msg00437.html
Content-length: 318

Hello,

I'd like to put forward the following:


x86 target		Mark Kettenis		kettenis@gnu.org

GNU/Linux/x86 native & host
			Jim Blandy		jimb@cygnus.com
			Mark Kettenis		kettenis@gnu.org

Solaris/x86 native & host
			Nick Duffek		nsd@cygnus.com
			Peter Schauer		Peter.Schauer@regent.e-technik.tu-muenchen.de

Andrew
From ac131313@cygnus.com Sat Apr 01 00:00:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Fernando Nasser <fnasser@cygnus.com>
Cc: gdb-patches@sourceware.cygnus.com, Elena Zannoni <ezannoni@cygnus.com>
Subject: Re: RFA: Patch to blockframe.c, frame.h, arm-tdep.c and fr30-tdep.c (prologue cache)
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <38BB2D7D.4081A59B@cygnus.com>
References: <38ACA4D6.993AFF74@cygnus.com>
X-SW-Source: 2000-q1/msg00411.html
Content-length: 1412

Fernando Nasser wrote:
> 
> I believe the following fixes a bug found by Elena.
> 
> Fernando
> 
> 2000-02-17  Fernando Nasser  <fnasser@totem.to.cygnus.com>
> 
>         * blockframe.c (check_prologue_cache, save_prologue_cache,
>         flush_prologue_cache): Slightly improved version of a prologue
> cache
>         used by some targets. Here there is a flush mechanism so we
> never use
>         stale data.
>         * frame.h: Prototypes for the above functions.
>         * arm-tdep.c (check_prologue_cache, save_prologue_cache):
> Deleted.
>         Moved (with changes) to blockframe.c.

First a technical question:  Does the code work with targets with
EXTRA_FRAME_INFO and INIT_EXTRA_FRAME_INFO?  I'm not sure if that should
be saved or not?

At a less technical level I also encountered the following problems:

	o	The function flush_prologue_cache()
		is called as flush_prolog_cache().
		As it stands, the patch won't compile.

	o	the change to frame.h creates
		``extern static ... PARAMS (())''

		The PARAMS bit isn't necessary
		and I suspect the ``extern static''
		was a cut/paste mistake.

		The header should also briefly
		explain what the interface is.

	o	the file fr30-tdep.c was changed
		but the ChangeLog didn't mention it

	o	btw your mail tool corrupted the
		patch (splitting several lines)

	o	I'd recommend making the FI param
		to save_prologue_cache const.

sorry,
	Andrew
From ac131313@cygnus.com Sat Apr 01 00:00:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: Philippe GIACINTI <Philippe.Giacinti@sxb.bsf.alcatel.fr>
Cc: gdb-patches@sourceware.cygnus.com, Michael Snyder <msnyder@cygnus.com>
Subject: Re: [PATCH] minor fixes in remote.c
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <38D5CB49.6F9CF39@cygnus.com>
References: <14549.49859.878539.158465@gargle.gargle.HOWL>
X-SW-Source: 2000-q1/msg00801.html
Content-length: 1918

Philippe GIACINTI wrote:
> 
> Hi,
> 
> Here is a patch including minor fixes in file gdb/remote.c:
> 
>      * remote.c (record_currthread): must call `set_thread' to change
>      general thread, in order to let stub know we have changed it.
>      * remote.c (remote_read_bytes): when we need to read more memory
>      than max buffer size, we have to reserve space for leading $ and
>      trailing # + checksum (i.e.: 4 char)
> 
> Best regards.
> --
> Philippe Giacinti - Alcatel Business Systems - PCD/SMB/SWPCC - CC S0645
> 1, route du Dr Albert Schweitzer - 67408 Illkirch Cedex - FRANCE
> Tel: +33 (0)3.90.67.62.10 - Fax: +33 (0)3.90.67.77.93
> mailto:Philippe.Giacinti@sxb.bsf.alcatel.fr
> 
>   ------------------------------------------------------------------------
> --- insight-20000314.old/gdb/remote.c   Fri Feb 18 18:00:18 2000
> +++ insight-20000314/gdb/remote.c       Fri Mar 17 09:00:54 2000

FYI,

> @@ -742,7 +742,7 @@
>  record_currthread (currthread)
>       int currthread;
>  {
> -  general_thread = currthread;
> +  set_thread (currthread,1);
> 
>    /* If this is a new thread, add it to GDB's thread list.
>       If we leave it up to WFI to do this, bad things will happen.  */

This is more MichaelS's domain.

> @@ -3439,7 +3439,8 @@
>        int todo;
>        int i;
> 
> -      todo = min (len, max_buf_size / 2);      /* num bytes that will fit */
> +      todo = min (len, max_buf_size / 2 - 4);  /* num bytes that will fit */
> +      /* -4 for leading $ and trailing # + checksum (2 hex chars) */
> 
>        /* construct "m"<memaddr>","<len>" */
>        /* sprintf (buf, "m%lx,%x", (unsigned long) memaddr, todo); */
> --- insight-20000314.old/gdb/ChangeLog  Tue Mar 14 03:37:24 2000
> +++ insight-20000314/gdb/ChangeLog      Fri Mar 17 13:29:21 2000

Can you expand on this one a little?
There were several nasty buffer overflow bugs but they should have been
fixed.

	Andrew
From ac131313@cygnus.com Sat Apr 01 00:00:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: GDB Patches <gdb-patches@sourceware.cygnus.com>
Subject: Re: Heads up - Alpha ISO-C fixes
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <38C072EC.56B02FA9@cygnus.com>
References: <38BF7D8C.BE18FAAF@cygnus.com>
X-SW-Source: 2000-q1/msg00492.html
Content-length: 3168

This one hurts.  Things to do post 5.0 is think about ISO-C-fying
mmalloc :-)

	Andrew
Sat Mar  4 13:02:09 2000  Andrew Cagney  <cagney@b1.cygnus.com>

	* utils.c (mcalloc), defs.h (mcalloc): Keep consistent with
 	"mmalloc.h" which means using PTRs.
	(init_malloc, msavestring, mstrsave): Convert to PTR free ISO-C.

Index: gdb/defs.h
===================================================================
RCS file: /cvs/src/src/gdb/defs.h,v
retrieving revision 1.8
diff -p -r1.8 defs.h
*** defs.h	2000/03/04 01:15:32	1.8
--- defs.h	2000/03/04 02:18:00
*************** extern int myread (int, char *, int);
*** 341,347 ****
  extern int query (char *, ...) ATTR_FORMAT (printf, 1, 2);
  
  #if !defined (USE_MMALLOC)
! extern PTR mcalloc (void *, size_t, size_t);
  extern PTR mmalloc (PTR, size_t);
  extern PTR mrealloc (PTR, PTR, size_t);
  extern void mfree (PTR, PTR);
--- 341,350 ----
  extern int query (char *, ...) ATTR_FORMAT (printf, 1, 2);
  
  #if !defined (USE_MMALLOC)
! /* NOTE: cagney/2000-03-04: The mmalloc functions need to use PTR
!    rather than void* so that they are consistent with
!    ../mmalloc/mmalloc.h. */
! extern PTR mcalloc (PTR, size_t, size_t);
  extern PTR mmalloc (PTR, size_t);
  extern PTR mrealloc (PTR, PTR, size_t);
  extern void mfree (PTR, PTR);
Index: gdb/utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.3
diff -p -r1.3 utils.c
*** utils.c	2000/03/04 00:40:40	1.3
--- utils.c	2000/03/04 02:18:07
*************** request_quit (signo)
*** 919,926 ****
  
  #if !defined (USE_MMALLOC)
  
! void *
! mcalloc (void *md, size_t number, size_t size)
  {
    return calloc (number, size);
  }
--- 919,926 ----
  
  #if !defined (USE_MMALLOC)
  
! PTR
! mcalloc (PTR md, size_t number, size_t size)
  {
    return calloc (number, size);
  }
*************** mfree (md, ptr)
*** 958,965 ****
  #if !defined (USE_MMALLOC) || defined (NO_MMCHECK)
  
  void
! init_malloc (md)
!      PTR md;
  {
  }
  
--- 958,964 ----
  #if !defined (USE_MMALLOC) || defined (NO_MMCHECK)
  
  void
! init_malloc (void *md)
  {
  }
  
*************** malloc_botch ()
*** 991,998 ****
  #endif
  
  void
! init_malloc (md)
!      PTR md;
  {
    if (!mmcheckf (md, malloc_botch, MMCHECK_FORCE))
      {
--- 990,996 ----
  #endif
  
  void
! init_malloc (void *md)
  {
    if (!mmcheckf (md, malloc_botch, MMCHECK_FORCE))
      {
*************** savestring (ptr, size)
*** 1149,1158 ****
  }
  
  char *
! msavestring (md, ptr, size)
!      PTR md;
!      const char *ptr;
!      int size;
  {
    register char *p = (char *) xmmalloc (md, size + 1);
    memcpy (p, ptr, size);
--- 1147,1153 ----
  }
  
  char *
! msavestring (void *md, const char *ptr, int size)
  {
    register char *p = (char *) xmmalloc (md, size + 1);
    memcpy (p, ptr, size);
*************** strsave (ptr)
*** 1171,1179 ****
  }
  
  char *
! mstrsave (md, ptr)
!      PTR md;
!      const char *ptr;
  {
    return (msavestring (md, ptr, strlen (ptr)));
  }
--- 1166,1172 ----
  }
  
  char *
! mstrsave (void *md, const char *ptr)
  {
    return (msavestring (md, ptr, strlen (ptr)));
  }
From kingdon@redhat.com Sat Apr 01 00:00:00 2000
From: Jim Kingdon <kingdon@redhat.com>
To: gdb-patches@sourceware.cygnus.com
Subject: Re: new GDB soon?
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <bpuu88cir.fsf@rtl.cygnus.com>
References: <200002071923.OAA30606@flib.gnu.ai.mit.edu> <389F25B8.18196557@cygnus.com> <200002072222.RAA32524@delysid.gnu.org>
X-SW-Source: 2000-q1/msg00093.html
Content-length: 207

> If someone sets me up with a copy of the Texinfo file(s), I would be
> happy to send some corrections or bug reports

http://sourceware.cygnus.com/cgi-bin/cvsweb.cgi/src/gdb/doc/gdb.texinfo?cvsroot=src
From ac131313@cygnus.com Sat Apr 01 00:00:00 2000
From: Andrew Cagney <ac131313@cygnus.com>
To: GDB Patches <gdb-patches@sourceware.cygnus.com>, "Insight (GDB GUI)" <insight@sourceware.cygnus.com>
Subject: GDB_FILE -> struct ui_file cleanup
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <389644AD.A93A9E7C@cygnus.com>
X-SW-Source: 2000-q1/msg00063.html
Content-length: 1928

Hmm, 

I've just checked in a jumbo cleanup patch (and it is going to hurt)
that replaces GDB_FILE / ``struct gdb_file'' with a uniform ``struct
ui_file''.

I've attatched the relevant ChangeLog entries.

	Andrew

ChangeLog:

Tue Feb  1 00:17:12 2000  Andrew Cagney  <cagney@b1.cygnus.com>

	* ui-file.c, ui-file.h: Rename gdb-file.h, gdb-file.c.  Rename
 	``struct gdb_file'' to ``struct ui_file''.  Delete typedef
 	GDB_FILE.
	
	* Makefile.in: Update.

	* ax-gdb.c, ax-general.c, ax.h, buildsym.c, c-lang.c, c-lang.h,
 	c-typeprint.c, c-valprint.c, ch-lang.c, ch-lang.h, ch-typeprint.c,
 	ch-valprint.c, command.c, command.h, convex-tdep.c, corefile.c,
 	cp-valprint.c, d10v-tdep.c, d30v-tdep.c, defs.h, expprint.c,
 	expression.h, f-lang.c, f-lang.h, f-typeprint.c, f-valprint.c,
 	frame.h, gdb-events.sh, gdb-file.c, gdb-file.h, gdbcmd.h,
 	gdbtypes.h, hppa-tdep.c, jv-lang.c, jv-lang.h, jv-typeprint.c,
 	jv-valprint.c, language.c, language.h, m2-lang.c, m2-lang.h,
 	m2-typeprint.c, m2-valprint.c, m3-nat.c, main.c, monitor.c,
 	printcmd.c, pyr-tdep.c, remote-mips.c, remote-sim.c, remote-udi.c,
 	remote.c, scm-lang.c, scm-lang.h, scm-valprint.c, ser-e7kpc.c,
 	ser-go32.c, ser-mac.c, ser-ocd.c, ser-unix.c, ser-unix.h,
 	serial.c, serial.h, stack.c, symfile.c, symmisc.c, tahoe-tdep.c,
 	target.c, target.h, top.c, top.h, typeprint.c, typeprint.h,
 	utils.c, v850ice.c, valprint.c, valprint.h, value.h,
 	config/pa/tm-hppa.h: Update.

ChangeLog-gdbtk:

Tue Feb  1 00:17:12 2000  Andrew Cagney  <cagney@b1.cygnus.com>

	* gdbtk-hooks.c, gdbtk-variable.c, gdbtk-wrapper.c,
 	gdbtk-wrapper.h, gdbtk.h: Update to reflect rename of gdb-file /
 	GDB_FILE to ui-file / ``struct ui_file''.

tui/ChangeLog:

Tue Feb  1 00:17:12 2000  Andrew Cagney  <cagney@b1.cygnus.com>

	* tui-file.c, tui-file.h, tuiDisassem.c, tuiIO.c, tuiIO.h,
 	tuiRegs.c: Update to reflect rename of gdb-file / GDB_FILE to
 	ui-file / ``struct ui_file''.
From scottb@netwinder.org Sat Apr 01 00:00:00 2000
From: "Scott Bambrough" <scottb@netwinder.org>
To: "Nick Clifton" <nickc@cygnus.com>
Cc: <fnasser@cygnus.com>, <gdb-patches@sourceware.cygnus.com>
Subject: Re: RFC: Patch to arm-tdep.c -- Register flavors
Date: Sat, 01 Apr 2000 00:00:00 -0000
Message-id: <000d01bf782d$3193e260$LocalHost@fiji>
References: <200002152356.PAA16995@elmo.cygnus.com>
X-SW-Source: 2000-q1/msg00167.html
Content-length: 1139

> : I think the default register names should be set by the port.  Most
Linux users
> : don't use the APCS/ATPCS register names.  I don't find them intuitive at
all
> : myself.
>
> On the other hand, Cygnus customers have complained about the lack of
> A{T}PCS compliant register naming schemes and this patch is part of
> the work that was done to make them happy.

I guess if they like that sort of thing.  I don't really know anyone who
uses them however.  Unless you do?

> : Is the othernames command really necessary?
>
> Documenting a command is not hard.  I suppoose the question the
> question is really "is this feature necessary ?".  I would certainly
> think that the ability to invoke target-specific commands from within
> GDB would be useful (*) be they register renaming commands or
> something else.

In this case I guess it is really "is this feature really necessary?".
There are two ways of accomplishing the same thing; the othername command
seems redundant to me.  Which is really the point I was trying to make.  I
probably shouldn't try to write email when I'm in a rush to get out the door
to go home :(.

Scott



^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2000-04-01  0:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-04-01  0:00 RFA: gdbarch_free Jim Blandy
2000-02-28 17:03 ` Andrew Cagney
2000-04-01  0:00   ` Jim Blandy
2000-03-01  8:52     ` Jim Blandy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox