From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH 1/2] gdb: replace pragmas with DIAGNOSTIC macros
Date: Wed, 1 Dec 2021 20:56:11 -0500 [thread overview]
Message-ID: <1eb6f676-06f2-d091-19c9-f3b522fb4a6e@efficios.com> (raw)
In-Reply-To: <ef91c0eb-4faf-225e-0549-38a08d65858b@suse.de>
On 2021-12-01 19:09, Tom de Vries wrote:
> On 11/23/21 10:14 PM, Simon Marchi via Gdb-patches wrote:
>> When introducing this code, I forgot that we had some macros for this.
>> Replace some "manual" pragma diagnostic with some DIAGNOSTIC_* macros,
>> provided by include/diagnostics.h.
>>
>> In diagnostics.h:
>>
>> - Add DIAGNOSTIC_ERROR, to enable a diagnostic at error level.
>> - Add DIAGNOSTIC_ERROR_SWITCH, to enable -Wswitch at error level, for
>> both gcc and clang.
>>
>
> I think you forgot the default definition
> ...
> #ifndef DIAGNOSTIC_ERROR_SWITCH
> # define DIAGNOSTIC_ERROR_SWITCH
> #endif
> ...
>
> Otherwise, LGTM.
>
> Thanks,
> - Tom
Right, fixed locally.
I would just like to get an Ack from a binutils maintainer, if possible,
since this touches the include directory.
Simon
next prev parent reply other threads:[~2021-12-02 1:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 21:14 Simon Marchi via Gdb-patches
2021-11-23 21:14 ` [PATCH 2/2] include, gdb: fix -Wswitch build errors with gcc 4.8 Simon Marchi via Gdb-patches
2021-12-02 0:25 ` Tom de Vries via Gdb-patches
2021-12-02 2:45 ` Simon Marchi via Gdb-patches
[not found] ` <ef91c0eb-4faf-225e-0549-38a08d65858b@suse.de>
2021-12-02 1:56 ` Simon Marchi via Gdb-patches [this message]
2021-12-02 2:44 ` [PATCH 1/2] gdb: replace pragmas with DIAGNOSTIC macros Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb6f676-06f2-d091-19c9-f3b522fb4a6e@efficios.com \
--to=gdb-patches@sourceware.org \
--cc=binutils@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox