From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0TJzMQ4oqGFXMgAAWB0awg (envelope-from ) for ; Wed, 01 Dec 2021 20:57:34 -0500 Received: by simark.ca (Postfix, from userid 112) id BAF941F0CE; Wed, 1 Dec 2021 20:57:34 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 41E1B1EDF0 for ; Wed, 1 Dec 2021 20:57:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE6BD385842D for ; Thu, 2 Dec 2021 01:57:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE6BD385842D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1638410253; bh=nCYJk4ZVZXfV9LuULYtmOpCd5AGY4kxOAPCLrXs4flk=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=jWGRtkUP8DiDoxLQjJNBi4lBci+WmPgG4IRIZu/lTVtLtwpmQ9xK37MN2tFpE7baj 85Z05zfC8WTfUUy/NpQaYJJeajgFLfZ6wnRr+1HTgjWsNTZMyS6nHtof14xeTv8a1J 5CcFrvfxBnCVsYDosdBgXA2i2evXkTpyN1q9I33w= Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 5E159385841D; Thu, 2 Dec 2021 01:56:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E159385841D Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id A2FF4369565; Wed, 1 Dec 2021 20:56:13 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id q-zhHeNGsNof; Wed, 1 Dec 2021 20:56:12 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 7A23D369564; Wed, 1 Dec 2021 20:56:12 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 7A23D369564 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Svckq3JhuHZT; Wed, 1 Dec 2021 20:56:12 -0500 (EST) Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) by mail.efficios.com (Postfix) with ESMTPSA id 353AA36986F; Wed, 1 Dec 2021 20:56:12 -0500 (EST) Message-ID: <1eb6f676-06f2-d091-19c9-f3b522fb4a6e@efficios.com> Date: Wed, 1 Dec 2021 20:56:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 1/2] gdb: replace pragmas with DIAGNOSTIC macros Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org, binutils@sourceware.org References: <20211123211437.3783065-1-simon.marchi@efficios.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-12-01 19:09, Tom de Vries wrote: > On 11/23/21 10:14 PM, Simon Marchi via Gdb-patches wrote: >> When introducing this code, I forgot that we had some macros for this. >> Replace some "manual" pragma diagnostic with some DIAGNOSTIC_* macros, >> provided by include/diagnostics.h. >> >> In diagnostics.h: >> >> - Add DIAGNOSTIC_ERROR, to enable a diagnostic at error level. >> - Add DIAGNOSTIC_ERROR_SWITCH, to enable -Wswitch at error level, for >> both gcc and clang. >> > > I think you forgot the default definition > ... > #ifndef DIAGNOSTIC_ERROR_SWITCH > # define DIAGNOSTIC_ERROR_SWITCH > #endif > ... > > Otherwise, LGTM. > > Thanks, > - Tom Right, fixed locally. I would just like to get an Ack from a binutils maintainer, if possible, since this touches the include directory. Simon