From: "Randolph Chung" <randolph@tausq.org>
To: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix reading floating point registers from core files on hppa-linux
Date: Sun, 14 Sep 2008 01:07:00 -0000 [thread overview]
Message-ID: <1e3eba760809131807u169ae563x9af4775b7c922d7b@mail.gmail.com> (raw)
In-Reply-To: <20080913234326.572F34E6A@hiauly1.hia.nrc.ca>
Hm.... gcore used to pass... wonder what changed. But your code below
looks reasonable.
randolph
On Sat, Sep 13, 2008 at 4:43 PM, John David Anglin
<dave@hiauly1.hia.nrc.ca> wrote:
> I noticed the failure of gcore.exp in testing the previous patch. This
> change fixes the problem. regcache_raw_supply only copies four bytes
> on hppa--unknown-linux-gnu.
>
> Ok?
>
> Dave
> --
> J. David Anglin dave.anglin@nrc-cnrc.gc.ca
> National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
>
> 2008-09-13 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
>
> * hppa-linux-tdep.c (hppa_linux_supply_fpregset): Correct iteration.
>
> Index: hppa-linux-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/hppa-linux-tdep.c,v
> retrieving revision 1.31
> diff -u -3 -p -r1.31 hppa-linux-tdep.c
> --- hppa-linux-tdep.c 21 Aug 2008 13:19:18 -0000 1.31
> +++ hppa-linux-tdep.c 13 Sep 2008 22:51:35 -0000
> @@ -474,12 +477,12 @@ hppa_linux_supply_fpregset (const struct
> int i, offset;
>
> offset = 0;
> - for (i = 0; i < 31; i++)
> + for (i = 0; i < 64; i++)
> {
> if (regnum == HPPA_FP0_REGNUM + i || regnum == -1)
> regcache_raw_supply (regcache, HPPA_FP0_REGNUM + i,
> buf + offset);
> - offset += 8;
> + offset += 4;
> }
> }
>
>
next prev parent reply other threads:[~2008-09-14 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 23:44 John David Anglin
2008-09-14 1:07 ` Randolph Chung [this message]
2008-09-14 1:53 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3eba760809131807u169ae563x9af4775b7c922d7b@mail.gmail.com \
--to=randolph@tausq.org \
--cc=dave@hiauly1.hia.nrc.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox