From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58598-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11467 invoked by alias); 14 Sep 2008 01:07:38 -0000
Received: (qmail 11386 invoked by uid 22791); 14 Sep 2008 01:07:37 -0000
X-Spam-Check-By: sourceware.org
Received: from mail-gx0-f10.google.com (HELO mail-gx0-f10.google.com) (209.85.217.10)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 14 Sep 2008 01:07:03 +0000
Received: by gxk3 with SMTP id 3so14721811gxk.0         for <gdb-patches@sourceware.org>; Sat, 13 Sep 2008 18:07:01 -0700 (PDT)
Received: by 10.150.181.7 with SMTP id d7mr3208178ybf.162.1221354421078;         Sat, 13 Sep 2008 18:07:01 -0700 (PDT)
Received: by 10.151.50.6 with HTTP; Sat, 13 Sep 2008 18:07:01 -0700 (PDT)
Message-ID: <1e3eba760809131807u169ae563x9af4775b7c922d7b@mail.gmail.com>
Date: Sun, 14 Sep 2008 01:07:00 -0000
From: "Randolph Chung" <randolph@tausq.org>
To: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
Subject: Re: [PATCH] Fix reading floating point registers from core files on hppa-linux
Cc: gdb-patches@sourceware.org
In-Reply-To: <20080913234326.572F34E6A@hiauly1.hia.nrc.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080913234326.572F34E6A@hiauly1.hia.nrc.ca>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-09/txt/msg00309.txt.bz2

Hm.... gcore used to pass... wonder what changed. But your code below
looks reasonable.

randolph

On Sat, Sep 13, 2008 at 4:43 PM, John David Anglin
<dave@hiauly1.hia.nrc.ca> wrote:
> I noticed the failure of gcore.exp in testing the previous patch.  This
> change fixes the problem.  regcache_raw_supply only copies four bytes
> on hppa--unknown-linux-gnu.
>
> Ok?
>
> Dave
> --
> J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
> National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
>
> 2008-09-13  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>
>
>        * hppa-linux-tdep.c (hppa_linux_supply_fpregset): Correct iteration.
>
> Index: hppa-linux-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/hppa-linux-tdep.c,v
> retrieving revision 1.31
> diff -u -3 -p -r1.31 hppa-linux-tdep.c
> --- hppa-linux-tdep.c   21 Aug 2008 13:19:18 -0000      1.31
> +++ hppa-linux-tdep.c   13 Sep 2008 22:51:35 -0000
> @@ -474,12 +477,12 @@ hppa_linux_supply_fpregset (const struct
>   int i, offset;
>
>   offset = 0;
> -  for (i = 0; i < 31; i++)
> +  for (i = 0; i < 64; i++)
>     {
>       if (regnum == HPPA_FP0_REGNUM + i || regnum == -1)
>         regcache_raw_supply (regcache, HPPA_FP0_REGNUM + i,
>                             buf + offset);
> -      offset += 8;
> +      offset += 4;
>     }
>  }
>
>