Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Fix xfail in gdb.ada/variant_record_field.exp
Date: Tue, 14 Oct 2025 18:04:14 +0200	[thread overview]
Message-ID: <1e27eccc-a76b-4085-b213-3cf1731dddc5@suse.de> (raw)
In-Reply-To: <87seflwmum.fsf@tromey.com>

On 10/14/25 4:59 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> The test-case contains an xfail for "[gcc_major_version] <= 14", which doesn't
> Tom> trigger because gcc has version 15.2.0, while gnatmake does have version
> Tom> 14.3.0:
> 
> This is ok.  I wonder if the other uses of gcc_major_version in gdb.ada
> should also be updated.
> 

Hi Tom,

thanks for the review, pushed.

Agreed, but it'd be nice to do so while being able to test the change.

For instance, in this case I first tried "[gnat_version_compare <= 14]" 
which didn't work, which testing pointed out to me.

Thanks,
- Tom

> Approved-By: Tom Tromey <tom@tromey.com>


  reply	other threads:[~2025-10-14 16:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-11 13:13 Tom de Vries
2025-10-14 14:59 ` Tom Tromey
2025-10-14 16:04   ` Tom de Vries [this message]
2025-10-14 16:17     ` Tom Tromey
2025-10-19 19:50       ` Tom de Vries
2025-10-19 21:02         ` Tom Tromey
2025-10-20  7:46           ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e27eccc-a76b-4085-b213-3cf1731dddc5@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox