From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BHYnF6907mi06DEAWB0awg (envelope-from ) for ; Tue, 14 Oct 2025 12:05:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b5hkFnsP; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=JVfUE8Ke; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=b5hkFnsP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=JVfUE8Ke; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4DA811E047; Tue, 14 Oct 2025 12:05:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C44A81E047 for ; Tue, 14 Oct 2025 12:05:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 53CE2385AC27 for ; Tue, 14 Oct 2025 16:05:01 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 2220A3858415 for ; Tue, 14 Oct 2025 16:04:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2220A3858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2220A3858415 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760457878; cv=none; b=DBMgjO2b7bRVvT7o5pXk4Dt0cQyx6li1Cb/jDK+aHCNtcfBy9I7k6+RKPI5uvB3UMAUp75A+NF/uK/qwZTC5b3pxULRZFi2jMVO7NtuhPBS0ra7c0i4IuYEshqvu+6e//JG5qJOJN4qj96l/RUweF+6hinY9S6BTwCLRWlc6JaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760457878; c=relaxed/simple; bh=Bgpp7WR5WIISP1QdMgZeOp9lwwWTnOCZ2gx9SsAsIKc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=IC6yLeNpgDEuzNBi/aUj6R5bV3FIyz68tzObEFcadW7P0dSvKjZP76I2C+615+/4xzYn15iDCPxn+IN82lHb6pxSLwmszkaAhz+gWxJp7X2LuMiqcJOtUtWwp6fMHs/JdLDpXHih8kXCTC3mkeV9+jUf6qauGGQXvL3kt1Pf0P0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 74B8C21D0E; Tue, 14 Oct 2025 16:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1760457854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fC7sfY5524E2YZCOuxtwEd+f+EltKMqvGgQm/vhcYFo=; b=b5hkFnsPOtHMVVzmvVqh74QsPQpUJcqX4reD8LnL4B6lLzZntiSBJgZF5XvIouzCGNjD47 g003h447LNrNGRsuyJHbj08VPscnQUYxclIepv8tIwf6JCQfLRNB/x+sA1rIw3Eurxd9EN rg5kdZh1e7XnXjtk9YwtZNhH36KVcro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1760457854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fC7sfY5524E2YZCOuxtwEd+f+EltKMqvGgQm/vhcYFo=; b=JVfUE8KekgbF1qtx+13BVxtuWVyR0eB4t2wxRfEKHJv0n8EI5oGvMDsLTDfaj1pjkzKQUY 3kVOC5vaQtQo0hBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=b5hkFnsP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=JVfUE8Ke DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1760457854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fC7sfY5524E2YZCOuxtwEd+f+EltKMqvGgQm/vhcYFo=; b=b5hkFnsPOtHMVVzmvVqh74QsPQpUJcqX4reD8LnL4B6lLzZntiSBJgZF5XvIouzCGNjD47 g003h447LNrNGRsuyJHbj08VPscnQUYxclIepv8tIwf6JCQfLRNB/x+sA1rIw3Eurxd9EN rg5kdZh1e7XnXjtk9YwtZNhH36KVcro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1760457854; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fC7sfY5524E2YZCOuxtwEd+f+EltKMqvGgQm/vhcYFo=; b=JVfUE8KekgbF1qtx+13BVxtuWVyR0eB4t2wxRfEKHJv0n8EI5oGvMDsLTDfaj1pjkzKQUY 3kVOC5vaQtQo0hBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5FE94139B0; Tue, 14 Oct 2025 16:04:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CF8rFn507mhaWgAAD6G6ig (envelope-from ); Tue, 14 Oct 2025 16:04:14 +0000 Message-ID: <1e27eccc-a76b-4085-b213-3cf1731dddc5@suse.de> Date: Tue, 14 Oct 2025 18:04:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix xfail in gdb.ada/variant_record_field.exp To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20251011131337.5877-1-tdevries@suse.de> <87seflwmum.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87seflwmum.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 74B8C21D0E X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,suse.de:dkim,tromey.com:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/14/25 4:59 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> The test-case contains an xfail for "[gcc_major_version] <= 14", which doesn't > Tom> trigger because gcc has version 15.2.0, while gnatmake does have version > Tom> 14.3.0: > > This is ok. I wonder if the other uses of gcc_major_version in gdb.ada > should also be updated. > Hi Tom, thanks for the review, pushed. Agreed, but it'd be nice to do so while being able to test the change. For instance, in this case I first tried "[gnat_version_compare <= 14]" which didn't work, which testing pointed out to me. Thanks, - Tom > Approved-By: Tom Tromey