Re: [PATCH] gdb/Windows testsuite: Avoid "bad" words in exe names

[Pedro Alves <pedro@palves.net>]

Hi Andrew,

On 2026-07-10 15:41, Andrew Burgess wrote:

> The change looks fine, but I wonder if we should factor this mapping
> into a helper function?  There are tests that setup multiple
> executables, and a common pattern is to call standard_output_file rather
> than building the names from BINFILE.  It might be helpful if we had a
> helper proc that we could call if needed in these cases.
> 
> Or maybe standard_output_file could use parse_some_args to allow
> something like:
> 
>   set binfile [standard_output_file -exec ${binfile_basename}]
> 
> with '-exec' being a flag to indicate we're creating an executable, in
> which ase BINFILE_BASENAME would have the string mapping applied?
> 
> Just a thought though, we can always tweak things later if you'd rather
> stick with this.
> 

Yeah, this approach has some fragility to it.  I just now sent an alternative
approach, based on embedding a manifest into the test executables:

 https://inbox.sourceware.org/gdb-patches/17aacd11-cc42-43eb-8328-bdcedcc0dfb5@palves.net/

That should be more robust, and let us not have to worry about this ever again (fingers crossed).

> Reviewed-By: Andrew Burgess <aburgess@redhat.com>

Thank you.

Pedro Alves