From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id c3zhFqtEUWpQDwIAWB0awg (envelope-from ) for ; Fri, 10 Jul 2026 15:14:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 4C67A1E070; Fri, 10 Jul 2026 15:14:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C218D1E070 for ; Fri, 10 Jul 2026 15:14:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 026514BA23E9 for ; Fri, 10 Jul 2026 19:14:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 026514BA23E9 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by sourceware.org (Postfix) with ESMTPS id 614324BA2E3E for ; Fri, 10 Jul 2026 19:14:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 614324BA2E3E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 614324BA2E3E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783710866; cv=none; b=Tlken65Oqboe68pe/TPlEaUJ+rkakZo6XBP4aA6Eb092sLuMg1Lm9d/6Hgu7EqvRZN1C0ZJx31XpyNMHCFeRWX2whPHQfhuEvks5Bq7BJYCqsaD7F8TyWwMGkUkGZVTXSys89gbR4eNpQ0aECRQhEDdmsg7fpVE67Kh4KXcPTy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783710866; c=relaxed/simple; bh=bUKfQJxm8Qr3mouf8NkQfdIS9YAfB1/kHfGcinI+Uf0=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=YzXf8cz+YlellXzCY2lD6VTubU3Y8gAULJeSkaz3q8aZdR3iRIdyJkwf8Qj26ajrkFNwvHV8Pzoys/0+psmhydRIReWGFYMFYFL/PjzrgcseKWG52bAftH2uo2a9iWOT4V3wt50wUjrFqq0uHW3w5H0dvb0mLfdxrBal1eL8WvY= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 614324BA2E3E Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493b779003fso6083825e9.3 for ; Fri, 10 Jul 2026 12:14:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783710865; x=1784315665; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ZKxq5h2ikHiS8nLqkvtgS2Fn5qcxya8u8Z6b59yCEgQ=; b=lj2V1U0RUFZYbi8CICOtexwUHeJq7a14vGabTgIAudAbyCiWBdZDifzGQplaZrglEp fpgXk5OyguGX5g/0kYfN0Dhzdl3fTl7MF03gzyN2KKTBZj1rn/Rd3itduWSMGbwUK8w1 BsgY59SvDCRKJTm6d2M9+XOBf6b8skkv5qBlheRGPM/HM8OLX8SkOgKw5WwuERfnbWIO UDmUkwVGVbMT4CTtE1Yp4KROm09EJlCtEIHrLLNglQQY/EkLf/3THhbPUfedQRjKEs5R 4XMjStxhk4ffW9LFg+YQx6zOqVJO8giSicth3GIOKbW8DXsLL+0xXzKMMGN+U7PJ9UWq A9yA== X-Forwarded-Encrypted: i=1; AHgh+RpTV8dsWGxGGnH6ICk0N9Y1g1o/dT8jD2btenwTSnIUqDOSQoQEDqxn2P+hOmqPfq0DnLshjTp10J1Fww==@sourceware.org X-Gm-Message-State: AOJu0YybwI0G9SHm3sNHWYUmKCBIv4uzC0q8PwWCE+DqvqqZgzTXmsuw vuyM0Vk5Fe70snHLvSiiQmvkzOPAIve2CUVSbf5kfS4ifNZPQKiJDweF X-Gm-Gg: AfdE7cn0ELo1fdgz7XfSi8Be6ZFpwbyQAemc0lB2g9abvXY4yETFJTYatY6tYsYEUUK tNCafCbcpvS3ve841sxhVhIFt8QL00c1+dHZc5DmgQmdsx+3Oqf6AOciv4lQCzluqzNoOCXgSeF VigCATub+TN8rsQQC8Bxehck+QJt7NkXrnSM5/Nd2PMZBkeBc+eCo03ftEDA62LoKi0s9bSGgIC lkn51/JkHH6cZ+D0fdgp4cyZPEGN0M4GlkQU/lqzpZENXDgW0Y7D14d8+cfCqgVEHX5BoKj3ARm 3gzpL8A04y0CIz82Oo51NpcYrowAoP2V6Hlo2ZLdawJSiTZXPxTUgZROxU/7tWvkipSayQDFNOo tzVd5RhR6SqY1g6rjtRcibMSRHb4PQ8OT6l2RxagDpzaOJjnoHqaouxehBr+e3doi1XgXoLjd6R 19pBLpTMCMF09wVlF1DZopL/UJWUhmX/LHn7lh33Yg6x+ICJLBY60+oCQ= X-Received: by 2002:a05:600c:608f:b0:493:c634:952 with SMTP id 5b1f17b1804b1-493f87d5d28mr1334595e9.7.1783710864943; Fri, 10 Jul 2026 12:14:24 -0700 (PDT) Received: from ?IPV6:2001:8a0:fae3:3700:f1ac:e6ce:cba9:ebd2? ([2001:8a0:fae3:3700:f1ac:e6ce:cba9:ebd2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6f373csm262924365e9.14.2026.07.10.12.14.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 12:14:24 -0700 (PDT) Message-ID: <1d43eb59-09e9-49ef-9a53-4c6d0d983117@palves.net> Date: Fri, 10 Jul 2026 20:14:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/Windows testsuite: Avoid "bad" words in exe names To: Andrew Burgess , gdb-patches@sourceware.org References: <20260709174351.431907-1-pedro@palves.net> <874ii6gb4c.fsf@redhat.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <874ii6gb4c.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Andrew, On 2026-07-10 15:41, Andrew Burgess wrote: > The change looks fine, but I wonder if we should factor this mapping > into a helper function? There are tests that setup multiple > executables, and a common pattern is to call standard_output_file rather > than building the names from BINFILE. It might be helpful if we had a > helper proc that we could call if needed in these cases. > > Or maybe standard_output_file could use parse_some_args to allow > something like: > > set binfile [standard_output_file -exec ${binfile_basename}] > > with '-exec' being a flag to indicate we're creating an executable, in > which ase BINFILE_BASENAME would have the string mapping applied? > > Just a thought though, we can always tweak things later if you'd rather > stick with this. > Yeah, this approach has some fragility to it. I just now sent an alternative approach, based on embedding a manifest into the test executables: https://inbox.sourceware.org/gdb-patches/17aacd11-cc42-43eb-8328-bdcedcc0dfb5@palves.net/ That should be more robust, and let us not have to worry about this ever again (fingers crossed). > Reviewed-By: Andrew Burgess Thank you. Pedro Alves