From: Simon Marchi <simark@simark.ca>
To: "Strasuns, Mihails" <mihails.strasuns@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 7/7] [gdb/testsuite] add jit-elf-util.h and run jit function
Date: Mon, 23 Mar 2020 07:14:56 -0400 [thread overview]
Message-ID: <1d0ff1a5-dda3-7559-21bb-8783d4fba508@simark.ca> (raw)
In-Reply-To: <MWHPR11MB004823B58A7FE4DA6C29B6DF95F00@MWHPR11MB0048.namprd11.prod.outlook.com>
On 2020-03-23 5:23 a.m., Strasuns, Mihails wrote:
> Hello,
>
> Here I was trying to preserve the old test flow as much as possible - I did seem a bit strange to me though.
> Original version relies on _not_ having DWARF debug info present (there is a comment about it in .exp file), the
> same applies for the refactored one. If you think simply emitting different function names in the first place is
> an equivalent change, I am more than happy to get rid of this :)
>
> Will address rest of comments and submit a new patchset soon, thanks for review!
Yes, it's a good idea to keep the tests testing binaries without debug info. But
I think it should be possible to generate binaries without debug info, but with
the right function names in the first place, isn't it? These are not inter-dependent?
Simon
next prev parent reply other threads:[~2020-03-23 11:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 12:42 [PATCH 0/7] refactor and enhance jit testing Mihails Strasuns
2020-02-18 12:42 ` [PATCH 3/7] [gdb/testsuite] share jit-protocol.h by all jit tests Mihails Strasuns
2020-02-19 21:23 ` Tom Tromey
2020-03-22 16:00 ` Simon Marchi
2020-02-18 12:42 ` [PATCH 5/7] [gdb/testsuite] add lib/jit-elf-helpers.exp Mihails Strasuns
2020-03-23 0:52 ` Simon Marchi
2020-02-18 12:42 ` [PATCH 1/7] [gdb/testsuite] allow more registers in reader test Mihails Strasuns
2020-02-19 21:22 ` Tom Tromey
2020-03-21 16:03 ` Simon Marchi
2020-03-22 2:09 ` Simon Marchi
2020-02-18 12:42 ` [PATCH 6/7] [gdb/testsuite] use -Ttext-segment for jit-elf tests Mihails Strasuns
2020-03-23 3:03 ` Simon Marchi
2020-02-18 12:42 ` [PATCH 7/7] [gdb/testsuite] add jit-elf-util.h and run jit function Mihails Strasuns
2020-03-23 3:13 ` Simon Marchi
2020-03-23 9:23 ` Strasuns, Mihails
2020-03-23 11:14 ` Simon Marchi [this message]
2020-02-18 12:42 ` [PATCH 4/7] [gdb/testsuite] use args as lib list for jit-elf tests Mihails Strasuns
2020-03-23 0:04 ` Simon Marchi
2020-03-23 0:35 ` Simon Marchi
2020-02-18 12:42 ` [PATCH 2/7] [gdb/testsuite] structured rename of jit test files Mihails Strasuns
2020-02-19 21:23 ` Tom Tromey
2020-03-22 2:47 ` Simon Marchi
2020-02-26 13:56 ` [PATCH 0/7] refactor and enhance jit testing Strasuns, Mihails
2020-03-18 12:48 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d0ff1a5-dda3-7559-21bb-8783d4fba508@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=mihails.strasuns@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox